Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Choose TARGET_OBJECT_STACK_MEMORY and TARGET_OBJECT_MEMORY in read_value_memory
Date: Fri, 22 Apr 2016 15:54:00 -0000	[thread overview]
Message-ID: <571A490C.3010005@redhat.com> (raw)
In-Reply-To: <1461059620-27870-1-git-send-email-yao.qi@linaro.org>

On 04/19/2016 10:53 AM, Yao Qi wrote:
> Before this patch
> https://sourceware.org/ml/gdb-patches/2014-02/msg00709.html
> read_value_memory checks parameter 'stack', and call read_stack or
> read_memory respectively.  However, 'stack' is not checked and
> TARGET_OBJECT_MEMORY is always used in target_xfer_partial, which is
> a mistake in the patch above.
> 
> This patch checks parameter 'stack', and choose TARGET_OBJECT_MEMORY
> or TARGET_OBJECT_STACK_MEMORY accordingly.
> 
> gdb:
> 
> 2016-04-19  Yao Qi  <yao.qi@linaro.org>
> 
> 	* valops.c (read_value_memory): New local variable 'stack'.
> 	Set it to either TARGET_OBJECT_STACK_MEMORY or
> 	TARGET_OBJECT_MEMORY.

LGTM.

Thanks,
Pedro Alves


  reply	other threads:[~2016-04-22 15:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-19  9:54 Yao Qi
2016-04-22 15:54 ` Pedro Alves [this message]
2016-04-22 16:21   ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571A490C.3010005@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox