From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34564 invoked by alias); 22 Apr 2016 15:54:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34476 invoked by uid 89); 22 Apr 2016 15:54:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 22 Apr 2016 15:53:50 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8BF09C057EC2; Fri, 22 Apr 2016 15:53:49 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3MFrmGX007890; Fri, 22 Apr 2016 11:53:48 -0400 Subject: Re: [PATCH] Choose TARGET_OBJECT_STACK_MEMORY and TARGET_OBJECT_MEMORY in read_value_memory To: Yao Qi , gdb-patches@sourceware.org References: <1461059620-27870-1-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <571A490C.3010005@redhat.com> Date: Fri, 22 Apr 2016 15:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1461059620-27870-1-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00533.txt.bz2 On 04/19/2016 10:53 AM, Yao Qi wrote: > Before this patch > https://sourceware.org/ml/gdb-patches/2014-02/msg00709.html > read_value_memory checks parameter 'stack', and call read_stack or > read_memory respectively. However, 'stack' is not checked and > TARGET_OBJECT_MEMORY is always used in target_xfer_partial, which is > a mistake in the patch above. > > This patch checks parameter 'stack', and choose TARGET_OBJECT_MEMORY > or TARGET_OBJECT_STACK_MEMORY accordingly. > > gdb: > > 2016-04-19 Yao Qi > > * valops.c (read_value_memory): New local variable 'stack'. > Set it to either TARGET_OBJECT_STACK_MEMORY or > TARGET_OBJECT_MEMORY. LGTM. Thanks, Pedro Alves