Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>,
	Walfred Tedeschi <walfred.tedeschi@intel.com>
Cc: brobecker@adacore.com, gdb-patches@sourceware.org
Subject: Re: [PATCH V2 0/2] Split tdesc_(amd64|i386)_mpx into tdesc(amd64|i386)_mpx_* and tdesc(amd64|i386)_avx_mpx_*
Date: Thu, 14 Apr 2016 11:33:00 -0000	[thread overview]
Message-ID: <570F8019.3060101@redhat.com> (raw)
In-Reply-To: <864mb4mqkm.fsf@gmail.com>

On 04/14/2016 11:29 AM, Yao Qi wrote:
> Walfred Tedeschi <walfred.tedeschi@intel.com> writes:
> 
>> CPU features can occur in any combination. The current assumption that 
>> feature "A" implies in feature "B" does not necessarily hold.
>>  
>> This patch series construct an additional combination of the Intel(R) 
>> Memory Protection Extensions (MPX) with Intel(R) Advanced Vector 
>> Extensions (AVX).
> 
> First of all, I am not against your patches.  Just think a little more
> after reading them...
> 
> This reveals a problem in gdb target description.  It doesn't scale very
> well if processors have multiple different features, and features can be
> combined differently.  A processor family has three features A, B, and
> C, and each processor implementation may have one, two or three of these
> features.  In gdb target description, we need to have many *.xml and *.c
> files, for these combinations like, A, B, C, AB, AC, BC, and ABC.
> 
> The root cause is that target description are static and pre-generated.
> If the target description can be generated dynamically according to the
> cpuid or AT_HWCAP, that would be simpler.  In this way, we only have to
> define target descriptions for feature A, B, and C, and GDB/GDBserver
> combine them together in the runtime.

I agree.  This is not the first time this is suggested.  If someone were
to do it, I'd be in favor too.

Thanks,
Pedro Alves


  reply	other threads:[~2016-04-14 11:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03 17:26 Walfred Tedeschi
2016-03-03 17:25 ` [PATCH V2 2/2] Re-factor (i386|amd64)mpx target descriptors Walfred Tedeschi
2016-04-13 12:05   ` Pedro Alves
2016-03-03 17:26 ` [PATCH V2 1/2] Add redundant target descriptor for tdesc(amd64|i386)_avx_mpx_* Walfred Tedeschi
2016-04-13 12:05   ` Pedro Alves
2016-04-13 12:18     ` Walfred Tedeschi
2016-04-14 10:00     ` Walfred Tedeschi
2016-04-14 10:29 ` [PATCH V2 0/2] Split tdesc_(amd64|i386)_mpx into tdesc(amd64|i386)_mpx_* and tdesc(amd64|i386)_avx_mpx_* Yao Qi
2016-04-14 11:33   ` Pedro Alves [this message]
2016-04-14 12:21     ` Walfred Tedeschi
2016-04-14 13:28       ` Build xml target descriptions at run time Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570F8019.3060101@redhat.com \
    --to=palves@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    --cc=walfred.tedeschi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox