Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Cc: qiyaoltc@gmail.com
Subject: Re: [PATCH] gdbserver-base.exp: Copy file to standard output directory in ${board}_download
Date: Tue, 12 Apr 2016 18:08:00 -0000	[thread overview]
Message-ID: <570D39A7.7040001@redhat.com> (raw)
In-Reply-To: <1460483287-23953-1-git-send-email-simon.marchi@ericsson.com>

On 04/12/2016 06:48 PM, Simon Marchi wrote:

>  proc ${board}_download { board host dest } {
> +    file copy -force $host [standard_output_file $dest]
>      return $host
>  }

I think this should be:

   set dest [standard_output_file $dest]
   file copy -force $host $dest
   return $dest

Don't we need to consider the case of $dest being an absolute path?

Thanks,
Pedro Alves


  reply	other threads:[~2016-04-12 18:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12 17:48 Simon Marchi
2016-04-12 18:08 ` Pedro Alves [this message]
2016-04-12 18:37   ` Simon Marchi
2016-04-12 18:45     ` Pedro Alves
2016-04-12 19:44       ` Simon Marchi
2016-04-13 11:21         ` Pedro Alves
2016-04-13 11:33       ` Yao Qi
2016-04-13 14:18         ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570D39A7.7040001@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox