From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-130881-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 99075 invoked by alias); 12 Apr 2016 18:08:46 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 98827 invoked by uid 89); 12 Apr 2016 18:08:45 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 12 Apr 2016 18:08:42 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id CCAA57F36F;	Tue, 12 Apr 2016 18:08:40 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3CI8dWj016157;	Tue, 12 Apr 2016 14:08:40 -0400
Subject: Re: [PATCH] gdbserver-base.exp: Copy file to standard output directory in ${board}_download
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
References: <1460483287-23953-1-git-send-email-simon.marchi@ericsson.com>
Cc: qiyaoltc@gmail.com
From: Pedro Alves <palves@redhat.com>
Message-ID: <570D39A7.7040001@redhat.com>
Date: Tue, 12 Apr 2016 18:08:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <1460483287-23953-1-git-send-email-simon.marchi@ericsson.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-04/txt/msg00253.txt.bz2

On 04/12/2016 06:48 PM, Simon Marchi wrote:

>  proc ${board}_download { board host dest } {
> +    file copy -force $host [standard_output_file $dest]
>      return $host
>  }

I think this should be:

   set dest [standard_output_file $dest]
   file copy -force $host $dest
   return $dest

Don't we need to consider the case of $dest being an absolute path?

Thanks,
Pedro Alves