From: Pedro Alves <palves@redhat.com>
To: Martin Galvan <martin.galvan@tallertechnologies.com>,
gdb-patches@sourceware.org, simon.marchi@ericsson.com
Subject: Re: [PATCH v2] value: Make accessor methods' parameters const-correct
Date: Fri, 08 Apr 2016 17:49:00 -0000 [thread overview]
Message-ID: <5707EF18.90505@redhat.com> (raw)
In-Reply-To: <1460059990-15871-1-git-send-email-martin.galvan@tallertechnologies.com>
On 04/07/2016 09:13 PM, Martin Galvan wrote:
> I did a quick pass over value.c and value.h and made some of the accessor methods'
> pass-by-reference parameters const-correct. Besides the obvious benefits, this is
> required if we want to use them on values that are already declared as const
> (such as the parameters to lval_funcs).
>
> There's probably a lot more stuff that can be made const, here and elsewhere.
>
> I have write access and copyright assignment. Ok to commit?
>
OK.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-04-08 17:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 20:13 Martin Galvan
2016-04-08 17:49 ` Pedro Alves [this message]
2016-04-08 18:12 ` Martin Galvan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5707EF18.90505@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=martin.galvan@tallertechnologies.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox