From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130162 invoked by alias); 8 Apr 2016 17:49:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130151 invoked by uid 89); 8 Apr 2016 17:49:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:581 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 08 Apr 2016 17:49:15 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1D0863B756; Fri, 8 Apr 2016 17:49:14 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u38HnCZn008893; Fri, 8 Apr 2016 13:49:13 -0400 Subject: Re: [PATCH v2] value: Make accessor methods' parameters const-correct To: Martin Galvan , gdb-patches@sourceware.org, simon.marchi@ericsson.com References: <1460059990-15871-1-git-send-email-martin.galvan@tallertechnologies.com> From: Pedro Alves Message-ID: <5707EF18.90505@redhat.com> Date: Fri, 08 Apr 2016 17:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1460059990-15871-1-git-send-email-martin.galvan@tallertechnologies.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00184.txt.bz2 On 04/07/2016 09:13 PM, Martin Galvan wrote: > I did a quick pass over value.c and value.h and made some of the accessor methods' > pass-by-reference parameters const-correct. Besides the obvious benefits, this is > required if we want to use them on values that are already declared as const > (such as the parameters to lval_funcs). > > There's probably a lot more stuff that can be made const, here and elsewhere. > > I have write access and copyright assignment. Ok to commit? > OK. Thanks, Pedro Alves