Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Heckel, Bernhard" <bernhard.heckel@intel.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "brobecker@adacore.com" <brobecker@adacore.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/3] fort_dyn_array: Enable dynamic member types inside a structure.
Date: Thu, 07 Apr 2016 06:03:00 -0000	[thread overview]
Message-ID: <5705F82F.2070505@intel.com> (raw)
In-Reply-To: <86d1q2n2hp.fsf@gmail.com>

On 06/04/2016 18:09, Yao Qi wrote:
> "Heckel, Bernhard" <bernhard.heckel@intel.com> writes:
>
>> This should not be a  problem as for all dynamic types we do first a
>> copy of the type before we start to resolve it.
> Can you show me the code copying the type?
>
>> Therefore, next time when we print variables from the target we have
>> to resolve it's type again (as we resolved only the copy before).
In gdb/gdbtypes.c, line 2027 (line incl. patch)

     static struct type *
     resolve_dynamic_struct (struct type *type,
                 struct property_addr_info *addr_stack)
    {
      struct type *resolved_type;
      int i;
      unsigned resolved_type_bit_length = 0;

     gdb_assert (TYPE_CODE (type) == TYPE_CODE_STRUCT);
     gdb_assert (TYPE_NFIELDS (type) > 0);

     resolved_type = copy_type (type);

The same you find in:
- resolve_dynamic_array
- resolve_dynamic_range
- resolve_dynamic_union



Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

  reply	other threads:[~2016-04-07  6:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17  8:43 [PATCH 0/3] fortran: Enable arrays of structures with dynamic member types Bernhard Heckel
2016-03-17  8:43 ` [PATCH 2/3] fort_dyn_array: Support evaluation of dynamic elements inside arrays Bernhard Heckel
2016-04-04  9:22   ` [PATCH 2/3][PING] " Heckel, Bernhard
2016-04-04 13:42   ` [PATCH 2/3] " Yao Qi
2016-03-17  8:43 ` [PATCH 1/3] fort_dyn_array: Enable dynamic member types inside a structure Bernhard Heckel
2016-04-04  9:22   ` [PATCH 1/3][PING] " Heckel, Bernhard
2016-04-04 13:31   ` [PATCH 1/3] " Yao Qi
2016-04-04 16:24     ` Yao Qi
2016-04-05  7:31     ` Heckel, Bernhard
2016-04-05 10:47       ` Yao Qi
2016-04-05 12:42         ` Heckel, Bernhard
2016-04-06 16:09           ` Yao Qi
2016-04-07  6:03             ` Heckel, Bernhard [this message]
2016-03-17  8:43 ` [PATCH 3/3] fort_dyn_array: Use value constructor instead of raw-buffer manipulation Bernhard Heckel
2016-04-04 13:54   ` Yao Qi
2016-04-05  9:31     ` Heckel, Bernhard
2016-04-04  9:21 ` [PATCH 0/3][PING] fortran: Enable arrays of structures with dynamic member types Heckel, Bernhard
2016-04-04 10:50 ` [PATCH 0/3] " Yao Qi
2016-04-04 12:16   ` Heckel, Bernhard
2016-04-04 14:41     ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5705F82F.2070505@intel.com \
    --to=bernhard.heckel@intel.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox