From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34848 invoked by alias); 7 Apr 2016 06:03:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33223 invoked by uid 89); 7 Apr 2016 06:03:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=incl, H*RU:HELO, Hx-spam-relays-external:HELO, commercial X-HELO: mga04.intel.com Received: from mga04.intel.com (HELO mga04.intel.com) (192.55.52.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Apr 2016 06:03:30 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP; 06 Apr 2016 23:03:29 -0700 X-ExtLoop1: 1 Received: from heckel-mobl3.ger.corp.intel.com (HELO [172.28.205.63]) ([172.28.205.63]) by fmsmga001.fm.intel.com with ESMTP; 06 Apr 2016 23:03:28 -0700 Subject: Re: [PATCH 1/3] fort_dyn_array: Enable dynamic member types inside a structure. To: Yao Qi References: <1458204189-13267-1-git-send-email-bernhard.heckel@intel.com> <1458204189-13267-2-git-send-email-bernhard.heckel@intel.com> <86h9fhpkkz.fsf@gmail.com> <570369BC.60407@intel.com> <86inzwnxik.fsf@gmail.com> <5703B2B4.4090209@intel.com> <86d1q2n2hp.fsf@gmail.com> Cc: "brobecker@adacore.com" , "gdb-patches@sourceware.org" From: "Heckel, Bernhard" Message-ID: <5705F82F.2070505@intel.com> Date: Thu, 07 Apr 2016 06:03:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <86d1q2n2hp.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00145.txt.bz2 T24gMDYvMDQvMjAxNiAxODowOSwgWWFvIFFpIHdyb3RlOgo+ICJIZWNrZWws IEJlcm5oYXJkIiA8YmVybmhhcmQuaGVja2VsQGludGVsLmNvbT4gd3JpdGVz Ogo+Cj4+IFRoaXMgc2hvdWxkIG5vdCBiZSBhICBwcm9ibGVtIGFzIGZvciBh bGwgZHluYW1pYyB0eXBlcyB3ZSBkbyBmaXJzdCBhCj4+IGNvcHkgb2YgdGhl IHR5cGUgYmVmb3JlIHdlIHN0YXJ0IHRvIHJlc29sdmUgaXQuCj4gQ2FuIHlv dSBzaG93IG1lIHRoZSBjb2RlIGNvcHlpbmcgdGhlIHR5cGU/Cj4KPj4gVGhl cmVmb3JlLCBuZXh0IHRpbWUgd2hlbiB3ZSBwcmludCB2YXJpYWJsZXMgZnJv bSB0aGUgdGFyZ2V0IHdlIGhhdmUKPj4gdG8gcmVzb2x2ZSBpdCdzIHR5cGUg YWdhaW4gKGFzIHdlIHJlc29sdmVkIG9ubHkgdGhlIGNvcHkgYmVmb3JlKS4K SW4gZ2RiL2dkYnR5cGVzLmMsIGxpbmUgMjAyNyAobGluZSBpbmNsLiBwYXRj aCkKCiAgICAgc3RhdGljIHN0cnVjdCB0eXBlICoKICAgICByZXNvbHZlX2R5 bmFtaWNfc3RydWN0IChzdHJ1Y3QgdHlwZSAqdHlwZSwKICAgICAgICAgICAg ICAgICBzdHJ1Y3QgcHJvcGVydHlfYWRkcl9pbmZvICphZGRyX3N0YWNrKQog ICAgewogICAgICBzdHJ1Y3QgdHlwZSAqcmVzb2x2ZWRfdHlwZTsKICAgICAg aW50IGk7CiAgICAgIHVuc2lnbmVkIHJlc29sdmVkX3R5cGVfYml0X2xlbmd0 aCA9IDA7CgogICAgIGdkYl9hc3NlcnQgKFRZUEVfQ09ERSAodHlwZSkgPT0g VFlQRV9DT0RFX1NUUlVDVCk7CiAgICAgZ2RiX2Fzc2VydCAoVFlQRV9ORklF TERTICh0eXBlKSA+IDApOwoKICAgICByZXNvbHZlZF90eXBlID0gY29weV90 eXBlICh0eXBlKTsKClRoZSBzYW1lIHlvdSBmaW5kIGluOgotIHJlc29sdmVf ZHluYW1pY19hcnJheQotIHJlc29sdmVfZHluYW1pY19yYW5nZQotIHJlc29s dmVfZHluYW1pY191bmlvbgoKCgpJbnRlbCBEZXV0c2NobGFuZCBHbWJIClJl Z2lzdGVyZWQgQWRkcmVzczogQW0gQ2FtcGVvbiAxMC0xMiwgODU1NzkgTmV1 YmliZXJnLCBHZXJtYW55ClRlbDogKzQ5IDg5IDk5IDg4NTMtMCwgd3d3Lmlu dGVsLmRlCk1hbmFnaW5nIERpcmVjdG9yczogQ2hyaXN0aW4gRWlzZW5zY2ht aWQsIENocmlzdGlhbiBMYW1wcmVjaHRlcgpDaGFpcnBlcnNvbiBvZiB0aGUg U3VwZXJ2aXNvcnkgQm9hcmQ6IE5pY29sZSBMYXUKUmVnaXN0ZXJlZCBPZmZp Y2U6IE11bmljaApDb21tZXJjaWFsIFJlZ2lzdGVyOiBBbXRzZ2VyaWNodCBN dWVuY2hlbiBIUkIgMTg2OTI4Cg== >From gdb-patches-return-130774-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Apr 07 08:15:12 2016 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 50120 invoked by alias); 7 Apr 2016 08:15:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 50058 invoked by uid 89); 7 Apr 2016 08:15:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=wednesday, Wednesday, Haswell, commercial X-HELO: mga14.intel.com Received: from mga14.intel.com (HELO mga14.intel.com) (192.55.52.115) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Apr 2016 08:14:50 +0000 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 07 Apr 2016 01:14:49 -0700 X-ExtLoop1: 1 Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga004.fm.intel.com with ESMTP; 07 Apr 2016 01:14:48 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.87]) by IRSMSX106.ger.corp.intel.com ([169.254.8.172]) with mapi id 14.03.0248.002; Thu, 7 Apr 2016 09:13:33 +0100 From: "Metzger, Markus T" To: Leonardo Boquillon CC: "gdb-patches@sourceware.org" , "Doug Evans (dje@google.com)" Subject: RE: [PATCH v2] Fix alignment of disassemble /r Date: Thu, 07 Apr 2016 08:15:00 -0000 Message-ID: References: <1459534685-10835-1-git-send-email-leonardo.boquillon@tallertechnologies.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00146.txt.bz2 Content-length: 3148 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBMZW9uYXJk byBCb3F1aWxsb24NCj4gW21haWx0bzpsZW9uYXJkby5ib3F1aWxsb25AdGFs bGVydGVjaG5vbG9naWVzLmNvbV0NCj4gU2VudDogV2VkbmVzZGF5LCBBcHJp bCA2LCAyMDE2IDc6NDcgUE0NCj4gVG86IE1ldHpnZXIsIE1hcmt1cyBUIDxt YXJrdXMudC5tZXR6Z2VyQGludGVsLmNvbT4NCj4gQ2M6IGdkYi1wYXRjaGVz QHNvdXJjZXdhcmUub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjJdIEZp eCBhbGlnbm1lbnQgb2YgZGlzYXNzZW1ibGUgL3INCj4gDQo+IEhpIE1hcmt1 cywNCj4gSSBza2V0Y2hlZCBhIGZ1bmN0aW9uIHRvIGNvbXB1dGUgdGhlIG9w Y29kZSBsZW5ndGggb24gcmVjb3JkLWJ0cmFjZSBbMV0gYnV0DQo+IEknbSBu b3Qgc3VyZSBob3cgdG8gdGVzdCBpdC4gQ291bGQgeW91IHBsZWFzZSBnaXZl IG1lIGEgaGludCBhYm91dCBob3cgdG8/DQo+IENhbiBiZSBpdCB0ZXN0ZWQg b3ZlciB4ODY/DQoNCkhpIExlb25hcmRvLA0KDQpUaGFua3MgZm9yIGFkZGlu ZyB0aGlzLg0KDQpGb3IgdGVzdGluZywgeW91J2QgbmVlZCBhIDR0aCBHZW5l cmF0aW9uIENvcmUgKEhhc3dlbGwpIG9yIGxhdGVyIG9yIGFueSBBdG9tDQpw cm9jZXNzb3IuICBUaGUgY29kZSBpcyB1c2VkIGJ5IHRoZSAicmVjb3JkIGlu c3RydWN0aW9uLWhpc3RvcnkiIGNvbW1hbmQNCndoaWNoIHJlcXVpcmVzIHRo ZSAiYnRyYWNlIiByZWNvcmRpbmcgbWV0aG9kOyB1c2UgInJlY29yZCBidHJh Y2UiIHRvIHN0YXJ0DQpyZWNvcmRpbmcuICBUaGVyZSBhcmUgdGVzdHMgaW4g Z2RiL3Rlc3RzdWl0ZS9nZGIuYnRyYWNlIHRoYXQgbWlnaHQgc2VydmUgYXMN CnRlbXBsYXRlLg0KDQpJZiB5b3UgZG9uJ3QgaGF2ZSB0aGUgbmVjZXNzYXJ5 IGhhcmR3YXJlIGZvciB0ZXN0aW5nIEkgY2FuIGRvIHRoaXMgZm9yIHlvdS4N Cg0KPiBzdGF0aWMgc2l6ZV90DQo+IGdldF9pbnNuX3NldF9sb25nZXN0X29w Y29kZShzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJjaCwgc3RydWN0DQo+IGRpc2Fz c2VtYmxlX2luZm8qIGRpLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgY29uc3Qgc3RydWN0IGJ0cmFjZV9pbnNuX2l0ZXJhdG9yICpiZWdpbiwN Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBi dHJhY2VfaW5zbl9pdGVyYXRvciAqZW5kKQ0KDQpJbmRlbnRhdGlvbiBpcyBv ZmYuDQoNCj4gew0KPiAgIHNpemVfdCBsb25nZXN0X29wY29kZSA9IDA7DQoN CkhvdyBhYm91dCBpbnQgaW5zdGVhZCBvZiBzaXplX3QgdG8gYXZvaWQgY29u dmVyc2lvbnMgYmVsb3c/DQoNCj4gICBzdHJ1Y3QgYnRyYWNlX2luc25faXRl cmF0b3IgaXQ7DQo+IA0KPiAgIGZvciAoaXQgPSAqYmVnaW47IGJ0cmFjZV9p bnNuX2NtcCAoJml0LCBlbmQpICE9IDA7IGJ0cmFjZV9pbnNuX25leHQgKCZp dCwgMSkpDQo+ICAgICB7DQo+ICAgICAgIGNvbnN0IHN0cnVjdCBidHJhY2Vf aW5zbiAqaW5zbiA9IGJ0cmFjZV9pbnNuX2dldCAoJml0KTsNCj4gDQo+ICAg ICAgIGlmIChpbnNuICE9IE5VTEwpDQo+IHsNCj4gIGNvbnN0IGludCBjdXJy ZW50X2xlbmd0aCA9IGdkYmFyY2hfcHJpbnRfaW5zbihnZGJhcmNoLCBpbnNu LT5wYywgZGkpOw0KDQpJJ2QgdXNlIGdkYl9pbnNuX2xlbmd0aCBoZXJlLg0K DQo+ICBsb25nZXN0X29wY29kZSA9DQo+ICAgIChjdXJyZW50X2xlbmd0aCA+ IGxvbmdlc3Rfb3Bjb2RlKSA/IGN1cnJlbnRfbGVuZ3RoIDogbG9uZ2VzdF9v cGNvZGU7DQo+IH0NCj4gICAgIH0NCj4gDQo+ICAgcmV0dXJuIGxvbmdlc3Rf b3Bjb2RlOw0KPiB9DQoNCkxvb2tzIGdvb2QuICBUaGlzIHNob3VsZCBhbHNv IHNpbXBsaWZ5IHlvdXIgcGF0Y2ggYXMgd2Ugd29uJ3QgbmVlZCB0d28NCnZl cnNpb25zIG9mIGdkYl9wcmV0dHlfcHJpbnRfaW5zbiBhbnltb3JlLg0KDQpM b29raW5nIGZvcndhcmQgdG8gdGhlIG5leHQgdmVyc2lvbiBvZiB5b3VyIHBh dGNoLg0KDQpSZWdhcmRzLA0KTWFya3VzLg0KSW50ZWwgRGV1dHNjaGxhbmQg R21iSApSZWdpc3RlcmVkIEFkZHJlc3M6IEFtIENhbXBlb24gMTAtMTIsIDg1 NTc5IE5ldWJpYmVyZywgR2VybWFueQpUZWw6ICs0OSA4OSA5OSA4ODUzLTAs IHd3dy5pbnRlbC5kZQpNYW5hZ2luZyBEaXJlY3RvcnM6IENocmlzdGluIEVp c2Vuc2NobWlkLCBDaHJpc3RpYW4gTGFtcHJlY2h0ZXIKQ2hhaXJwZXJzb24g b2YgdGhlIFN1cGVydmlzb3J5IEJvYXJkOiBOaWNvbGUgTGF1ClJlZ2lzdGVy ZWQgT2ZmaWNlOiBNdW5pY2gKQ29tbWVyY2lhbCBSZWdpc3RlcjogQW10c2dl cmljaHQgTXVlbmNoZW4gSFJCIDE4NjkyOAo= >From gdb-patches-return-130775-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Apr 07 11:12:59 2016 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 70333 invoked by alias); 7 Apr 2016 11:12:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 70256 invoked by uid 89); 7 Apr 2016 11:12:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=1767 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 07 Apr 2016 11:12:42 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 16BC5C056819; Thu, 7 Apr 2016 11:12:39 +0000 (UTC) Received: from cascais.lan (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u37BCbTc012925; Thu, 7 Apr 2016 07:12:38 -0400 From: Pedro Alves To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH] Fix gdb.server/solib-list.exp regression Date: Thu, 07 Apr 2016 11:12:00 -0000 Message-Id: <1460027557-20679-1-git-send-email-palves@redhat.com> X-SW-Source: 2016-04/txt/msg00147.txt.bz2 Content-length: 4649 Commit 7817ea46148d (Improve gdb_remote_download, remove gdb_download) caused: FAIL: gdb.server/solib-list.exp: non-stop 0: target extended-remote (timeout) FAIL: gdb.server/solib-list.exp: non-stop 0: continue (the program is no longer running) FAIL: gdb.server/solib-list.exp: non-stop 0: p libvar FAIL: gdb.server/solib-list.exp: non-stop 1: target extended-remote (timeout) FAIL: gdb.server/solib-list.exp: non-stop 1: continue (the program is no longer running) FAIL: gdb.server/solib-list.exp: non-stop 1: p libvar gdb.log shows: system interpreter is: /lib64/ld-linux-x86-64.so.2 ... spawn ../gdbserver/gdbserver --once :2347 /home/pedro/brno/pedro/gdb/mygit/build/gdb/testsuite/outputs/gdb.server/solib-list/ld-linux-x86-64.so.2 /home/pedro/brno/pedro/gdb/mygit/build/gdb/testsuite/outputs/gdb.server/solib-list/solib-list Process /home/pedro/brno/pedro/gdb/mygit/build/gdb/testsuite/outputs/gdb.server/solib-list/ld-linux-x86-64.so.2 created; pid = 18637 Cannot exec /home/pedro/brno/pedro/gdb/mygit/build/gdb/testsuite/outputs/gdb.server/solib-list/ld-linux-x86-64.so.2: No such file or directory. ... The test copied the interpreter to the outputs directory, however ld-linux-x86-64.so.2 is a relative symlink that when copied points nowhere: $ ls -l testsuite/outputs/gdb.server/solib-list/ total 52 -rwxrwxr-x. 1 pedro pedro 13450 Apr 7 10:52 gdb.log -rw-rw-r--. 1 pedro pedro 1512 Apr 7 10:52 gdb.sum lrwxrwxrwx. 1 pedro pedro 10 Apr 7 11:39 ld-linux-x86-64.so.2 -> ld-2.22.so -rwxrwxr-x. 1 pedro pedro 9464 Apr 7 11:39 solib-list -rw-rw-r--. 1 pedro pedro 3472 Apr 7 11:39 solib-list-lib.c.o -rw-rw-r--. 1 pedro pedro 2760 Apr 7 11:39 solib-list.o -rwxrwxr-x. 1 pedro pedro 9232 Apr 7 11:39 solib-list.so The copying comes from gdbserver_spawn -> gdbserver_download_current_prog -> gdb_remote_download. My first attempt at a fix made solib-list.exp resolve the interpreter symlink, so that the copying works, and that did make the test pass. However, I noticed something else, which can be reduced to this: gdb_load ${binfile} gdbserver_spawn gdb_load passes ${binfile} unmodified to the "file" command. If $binfile needs to be run through standard_output_file, that should be done before calling gdb_load, and it normally is. In solib-list.exp's case, the ${binfile} is the system interpreter, outside the outputs directory. Since gdbserver_download_current_prog copies the file to the outputs directory and runs it there, we'd end up with a mismatch between what gdbserver starts, and gdb loads. So to address that we'd have to have the test do: +proc gdb_realpath {filename} { + ... +} set interp_system [section_get ${binfile} .interp] +set interp_system [gdb_realpath $interp_system] +set interp_system [standard_output_file $interp_system] But that all seems like pointless copying/work in the first place. I think that instead, when local testing, we should make what gdbserver runs be exactly what was passed to gdb_load / gdb_file_cmd, which is what we used to do before commit 7817ea46148d (Improve gdb_remote_download, remove gdb_download), which did: set gdbserver_host_mtime [file mtime $host_exec] - if [is_remote target] { - set gdbserver_server_exec [gdb_download $host_exec] - } else { - set gdbserver_server_exec $host_exec - } + set gdbserver_server_exec [gdb_remote_download target $host_exec] gdb/ChangeLog: 2016-04-07 Pedro Alves * lib/gdbserver-support.exp (gdbserver_download_current_prog): Skip download if the target is local. --- gdb/testsuite/lib/gdbserver-support.exp | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/lib/gdbserver-support.exp b/gdb/testsuite/lib/gdbserver-support.exp index 67a8333..817331b 100644 --- a/gdb/testsuite/lib/gdbserver-support.exp +++ b/gdb/testsuite/lib/gdbserver-support.exp @@ -176,7 +176,16 @@ proc gdbserver_download_current_prog { } { if { $reuse == 0 } { set gdbserver_host_exec $host_exec set gdbserver_host_mtime [file mtime $host_exec] - set gdbserver_server_exec [gdb_remote_download target $host_exec] + + # If local testing, don't use gdb_remote_download, which would + # copy the file to the testcase's output directory. Use + # LAST_LOADED_FILE as is, so that gdbserver starts the exact + # same filename that will be handed to gdb's file command. + if [is_remote target] { + set gdbserver_server_exec [gdb_remote_download target $host_exec] + } else { + set gdbserver_server_exec $host_exec + } } return $gdbserver_server_exec -- 2.5.5