[PATCH] Fix gdb.threads/dlopen-libpthread.exp crash

[PATCH] Fix gdb.threads/dlopen-libpthread.exp crash

[Simon Marchi]

Following, commit

  6e774b13c3b81ac2599812adf058796948ce7e95 Make ftrace tests work with remote targets

the test gdb.threads/dlopen-libpthread.exp started to fail with:

  ERROR: error copying "/home/emaisin/build/binutils-gdb/gdb/testsuite/gdb.threads/dlopen-libpthread.so": no such file or directory

This is because the library path is not computed using
standard_output_file, so we try to gdb_load_shlibs an unexisting file.

gdb/testsuite/ChangeLog:

	* gdb.threads/dlopen-libpthread.exp: Set binfile_lib using
	standard_output_file.  Remove unused binfile variable.
---
 gdb/testsuite/gdb.threads/dlopen-libpthread.exp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.threads/dlopen-libpthread.exp b/gdb/testsuite/gdb.threads/dlopen-libpthread.exp
index 33789cc..206b16a 100644
--- a/gdb/testsuite/gdb.threads/dlopen-libpthread.exp
+++ b/gdb/testsuite/gdb.threads/dlopen-libpthread.exp
@@ -23,8 +23,7 @@ set testfile "dlopen-libpthread"
 set srcmainfile ${testfile}.c
 set srclibfile ${testfile}-lib.c
 set executable ${testfile}
-set binfile_lib ${objdir}/${subdir}/${executable}.so
-set binfile ${objdir}/${subdir}/${executable}
+set binfile_lib [standard_output_file ${executable}.so]
 set lib_dlopen [shlib_target_file ${executable}.so]
 
 # Use build_executable_own_libs as prelinked libpthread.so can produce false
-- 
2.8.1

Re: [PATCH] Fix gdb.threads/dlopen-libpthread.exp crash

[Pedro Alves]

On 04/06/2016 09:22 PM, Simon Marchi wrote:
> Following, commit
> 
>   6e774b13c3b81ac2599812adf058796948ce7e95 Make ftrace tests work with remote targets
> 
> the test gdb.threads/dlopen-libpthread.exp started to fail with:
> 
>   ERROR: error copying "/home/emaisin/build/binutils-gdb/gdb/testsuite/gdb.threads/dlopen-libpthread.so": no such file or directory
> 
> This is because the library path is not computed using
> standard_output_file, so we try to gdb_load_shlibs an unexisting file.
> 
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.threads/dlopen-libpthread.exp: Set binfile_lib using
> 	standard_output_file.  Remove unused binfile variable.

OK.  Thanks!

-- 
Pedro Alves

Re: [PATCH] Fix gdb.threads/dlopen-libpthread.exp crash

[Simon Marchi]

On 16-04-06 04:43 PM, Pedro Alves wrote:
> On 04/06/2016 09:22 PM, Simon Marchi wrote:
>> Following, commit
>>
>>   6e774b13c3b81ac2599812adf058796948ce7e95 Make ftrace tests work with remote targets
>>
>> the test gdb.threads/dlopen-libpthread.exp started to fail with:
>>
>>   ERROR: error copying "/home/emaisin/build/binutils-gdb/gdb/testsuite/gdb.threads/dlopen-libpthread.so": no such file or directory
>>
>> This is because the library path is not computed using
>> standard_output_file, so we try to gdb_load_shlibs an unexisting file.
>>
>> gdb/testsuite/ChangeLog:
>>
>> 	* gdb.threads/dlopen-libpthread.exp: Set binfile_lib using
>> 	standard_output_file.  Remove unused binfile variable.
> 
> OK.  Thanks!

Pushed, thanks for reporting!