From: Simon Marchi <simon.marchi@ericsson.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 1/2] Improve gdb_remote_download, remove gdb_download
Date: Tue, 05 Apr 2016 18:03:00 -0000 [thread overview]
Message-ID: <5703FDDC.1060500@ericsson.com> (raw)
In-Reply-To: <5703FC69.7010806@redhat.com>
On 16-04-05 01:56 PM, Pedro Alves wrote:
> On 04/05/2016 06:54 PM, Simon Marchi wrote:
>> On 16-04-05 01:47 PM, Pedro Alves wrote:
>
>>> Shouldn't this be, "When the DEST is remote, we simply send the
>>> file to DEST" ?.
>>
>> Right.
>>
>>>>
>>>> -# gdb_download
>>>> -#
>>>> -# Copy a file to the remote target and return its target filename.
>>>> -# Schedule the file to be deleted at the end of this test.
>>>> + set destname [remote_download target $fromfile $tofile]
>>>
>>> and thus here be "remote_download $dest" ?
>>
>> Right. I tested this procedure with a remote host, but with the target being
>> the same as the host, so it was working anyway...
>>
>> Fixed.
>
> OK with those fixed then.
>
> Thanks,
> Pedro Alves
>
Pushed, thanks!
prev parent reply other threads:[~2016-04-05 18:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 18:31 Simon Marchi
2016-04-04 18:31 ` [PATCH v2 2/2] Make ftrace tests work with remote targets Simon Marchi
2016-04-05 17:49 ` Pedro Alves
2016-04-05 18:04 ` Simon Marchi
2016-04-11 13:12 ` Yao Qi
2016-04-11 14:18 ` Simon Marchi
2016-04-05 17:47 ` [PATCH v2 1/2] Improve gdb_remote_download, remove gdb_download Pedro Alves
2016-04-05 17:54 ` Simon Marchi
2016-04-05 17:57 ` Pedro Alves
2016-04-05 18:03 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5703FDDC.1060500@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox