From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-130725-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 417 invoked by alias); 5 Apr 2016 18:03:16 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 400 invoked by uid 89); 5 Apr 2016 18:03:15 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: usplmg20.ericsson.net
Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 05 Apr 2016 18:03:11 +0000
Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78])	by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id 7A.1B.30335.3B7F3075; Tue,  5 Apr 2016 19:36:51 +0200 (CEST)
Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.80) with Microsoft SMTP Server id 14.3.248.2; Tue, 5 Apr 2016 14:03:08 -0400
Subject: Re: [PATCH v2 1/2] Improve gdb_remote_download, remove gdb_download
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
References: <1459794657-2087-1-git-send-email-simon.marchi@ericsson.com> <5703FA26.2080907@redhat.com> <5703FBD7.7020706@ericsson.com> <5703FC69.7010806@redhat.com>
From: Simon Marchi <simon.marchi@ericsson.com>
Message-ID: <5703FDDC.1060500@ericsson.com>
Date: Tue, 05 Apr 2016 18:03:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <5703FC69.7010806@redhat.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2016-04/txt/msg00097.txt.bz2

On 16-04-05 01:56 PM, Pedro Alves wrote:
> On 04/05/2016 06:54 PM, Simon Marchi wrote:
>> On 16-04-05 01:47 PM, Pedro Alves wrote:
> 
>>> Shouldn't this be, "When the DEST is remote, we simply send the
>>> file to DEST" ?.
>>
>> Right.
>>
>>>>  
>>>> -# gdb_download
>>>> -#
>>>> -# Copy a file to the remote target and return its target filename.
>>>> -# Schedule the file to be deleted at the end of this test.
>>>> +	set destname [remote_download target $fromfile $tofile]
>>>
>>> and thus here be "remote_download $dest" ?
>>
>> Right.  I tested this procedure with a remote host, but with the target being
>> the same as the host, so it was working anyway...
>>
>> Fixed.
> 
> OK with those fixed then.
> 
> Thanks,
> Pedro Alves
> 

Pushed, thanks!