Re: [PATCH] gdbserver: Handle 'v' packet while processing qSymbol.

[Pedro Alves <palves@redhat.com>]

On 03/12/2016 03:02 PM, Marcin Kościelnicki wrote:

>  gdb/ChangeLog                |  5 +++++
>  gdb/gdbserver/ChangeLog      | 10 ++++++++++
>  gdb/gdbserver/remote-utils.c | 41 +++++++++++++++++++++++++++--------------
>  gdb/gdbserver/server.c       |  4 ++--
>  gdb/gdbserver/server.h       |  4 ++++
>  gdb/remote.c                 | 22 +++++++++++++++++-----
>  6 files changed, 65 insertions(+), 21 deletions(-)
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index febe960..41f826e 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,8 @@
> +2016-03-12  Marcin Kościelnicki  <koriakin@0x04.net>
> +
> +	* remote.c (xfreep): New function.

You can use free_current_contents instead.

> +	(remote_check_symbols): Allocate own buffer for reply.
> +

> @@ -1499,21 +1499,35 @@ look_up_one_symbol (const char *name, CORE_ADDR *addrp, int may_ask_gdb)
>       main loop.  For now, this is an adequate approximation; allow
>       GDB to read from memory while it figures out the address of the
>       symbol.  */
> -  while (own_buf[0] == 'm')
> +  while (1)

Comment above is stale.

OK with those addressed.

Thanks,
Pedro Alves