From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118592 invoked by alias); 29 Mar 2016 22:00:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118515 invoked by uid 89); 29 Mar 2016 22:00:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=BAYES_00,KAM_ADVERT2,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1136, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 29 Mar 2016 22:00:46 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 2033C7F0A7; Tue, 29 Mar 2016 22:00:45 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2TM0gh2011738; Tue, 29 Mar 2016 18:00:43 -0400 Subject: Re: [PATCH] gdbserver: Handle 'v' packet while processing qSymbol. To: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= , gdb-patches@sourceware.org References: <1457794943-12954-1-git-send-email-koriakin@0x04.net> From: Pedro Alves Message-ID: <56FAFB0A.4070602@redhat.com> Date: Tue, 29 Mar 2016 22:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1457794943-12954-1-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-03/txt/msg00542.txt.bz2 On 03/12/2016 03:02 PM, Marcin Kościelnicki wrote: > gdb/ChangeLog | 5 +++++ > gdb/gdbserver/ChangeLog | 10 ++++++++++ > gdb/gdbserver/remote-utils.c | 41 +++++++++++++++++++++++++++-------------- > gdb/gdbserver/server.c | 4 ++-- > gdb/gdbserver/server.h | 4 ++++ > gdb/remote.c | 22 +++++++++++++++++----- > 6 files changed, 65 insertions(+), 21 deletions(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index febe960..41f826e 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,8 @@ > +2016-03-12 Marcin Kościelnicki > + > + * remote.c (xfreep): New function. You can use free_current_contents instead. > + (remote_check_symbols): Allocate own buffer for reply. > + > @@ -1499,21 +1499,35 @@ look_up_one_symbol (const char *name, CORE_ADDR *addrp, int may_ask_gdb) > main loop. For now, this is an adequate approximation; allow > GDB to read from memory while it figures out the address of the > symbol. */ > - while (own_buf[0] == 'm') > + while (1) Comment above is stale. OK with those addressed. Thanks, Pedro Alves