Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] S390: Add use of unavailable-stack frame ID
Date: Thu, 10 Mar 2016 20:26:00 -0000	[thread overview]
Message-ID: <56E1D869.3010006@redhat.com> (raw)
In-Reply-To: <m31t7m37zm.fsf@oc1027705133.ibm.com>

On 03/07/2016 10:19 AM, Andreas Arnez wrote:
> When determining the frame ID of an inline frame, GDB currently asserts
> that a valid ID of the underlying real frame is found, and that it does
> not match outer_frame_id.  From inline_frame_this_id():
>
>    /* For now, require we don't match outer_frame_id either (see
>       comment above).  */
>    gdb_assert (!frame_id_eq (*this_id, outer_frame_id));
>
> However, this assertion may fail when the real frame's unwinder can not
> determine the frame ID.  This happened on an s390x target with a binary
> that lacked call frame information and also confused the prologue
> analyzer, because then s390_frame_this_id() left the frame ID at its
> default.
>
> To fix this, this change enhances s390_frame_this_id such that an
> unavailable-stack frame ID is built if no frame base can be determined
> but the function address is available.
>

Seeing all these makes me want this:

  https://sourceware.org/ml/gdb-patches/2016-02/msg00778.html

even more.  :-)

Thanks,
Pedro Alves


  parent reply	other threads:[~2016-03-10 20:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-07 10:20 Andreas Arnez
2016-03-09 16:16 ` [PUSHED] " Andreas Arnez
2016-03-10 20:26 ` Pedro Alves [this message]
2016-03-11  9:24   ` Andreas Arnez
2016-03-15  8:12     ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E1D869.3010006@redhat.com \
    --to=palves@redhat.com \
    --cc=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox