From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46168 invoked by alias); 10 Mar 2016 20:26:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46112 invoked by uid 89); 10 Mar 2016 20:26:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 10 Mar 2016 20:26:19 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 9BF526DDDB; Thu, 10 Mar 2016 20:26:18 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2AKQHfV007541; Thu, 10 Mar 2016 15:26:17 -0500 Subject: Re: [PATCH] S390: Add use of unavailable-stack frame ID To: Andreas Arnez , gdb-patches@sourceware.org References: From: Pedro Alves Message-ID: <56E1D869.3010006@redhat.com> Date: Thu, 10 Mar 2016 20:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-03/txt/msg00167.txt.bz2 On 03/07/2016 10:19 AM, Andreas Arnez wrote: > When determining the frame ID of an inline frame, GDB currently asserts > that a valid ID of the underlying real frame is found, and that it does > not match outer_frame_id. From inline_frame_this_id(): > > /* For now, require we don't match outer_frame_id either (see > comment above). */ > gdb_assert (!frame_id_eq (*this_id, outer_frame_id)); > > However, this assertion may fail when the real frame's unwinder can not > determine the frame ID. This happened on an s390x target with a binary > that lacked call frame information and also confused the prologue > analyzer, because then s390_frame_this_id() left the frame ID at its > default. > > To fix this, this change enhances s390_frame_this_id such that an > unavailable-stack frame ID is built if no frame base can be determined > but the function address is available. > Seeing all these makes me want this: https://sourceware.org/ml/gdb-patches/2016-02/msg00778.html even more. :-) Thanks, Pedro Alves