From: "Marcin Kościelnicki" <koriakin@0x04.net>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Wei-cheng Wang <cole945@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/5 v4] powerpc: Support z-point type in gdbserver.
Date: Wed, 24 Feb 2016 17:39:00 -0000 [thread overview]
Message-ID: <56CDEAC0.5050905@0x04.net> (raw)
In-Reply-To: <20160224173657.740EF47F7@oc7340732750.ibm.com>
On 24/02/16 18:36, Ulrich Weigand wrote:
>> Another old approved patch that I'd like to push. Testing on
>> ppc+ppc64+ppc64le:
>>
>> gdb.base/dprintf.exp: agent: 1st dprintf UNSUPPORTED -> PASS×3
>> gdb.base/jit.exp: PIE: one_jit_test-1: set var libname =
>> "SHLIBDIR/jit-solib.so" PASS -> FAIL, on ppc64 only (I don't consider
>> that one a problem, since jit.exp already has lots of similiar FAILs for
>> this arch, nothing really new is broken here)
>> gdb.mi/mi-dprintf.exp: mi expect stop FAIL×5 -> PASS×4
>> gdb.threads/forking-threads-plus-breakpoint.exp: cond_bp_target=1:
>> detach_on_fork=on: displaced=off FAIL -> PASS×3
>> gdb.threads/process-dies-while-handling-bp.exp: non_stop=on:
>> cond_bp_target=1: KFAIL (memory error) -> KFAIL (prompt)
>> gdb.threads/process-dies-while-handling-bp.exp: non_stop=off:
>> cond_bp_target=[01]: inferior 1 exited PASS×2 -> KFAIL (PRMS: gdb/18749)
>>
>> Fixes a lot of gdb.trace tests if I enable tracepoints.
>>
>> On 27/06/15 18:21, Wei-cheng Wang wrote:
>>> Support z-point, so tracepoints and breakpoints can be inserted at the same
>>> location.
>>>
>>> gdb/gdbserver/ChangeLog
>>>
>>> 2015-06-27 Wei-cheng Wang <cole945@gmail.com>
>>>
>>> * linux-ppc-low.c (ppc_supports_z_point_type): New function:
>>> (ppc_insert_point, ppc_remove_point): Insert/remove z-packet breakpoints.
>>> (ppc64_emit_ops_vector): Add target ops - ppc_supports_z_point_type,
>>> ppc_insert_point, ppc_remove_point.
>
> Yes, this is also still OK.
>
> Thanks,
> Ulrich
>
Thanks, pushed.
next prev parent reply other threads:[~2016-02-24 17:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-27 16:21 [PATCH 1/5 v4] Remove tracepoint_action ops Wei-cheng Wang
2015-06-27 16:22 ` [PATCH 3/5 v4] Fix argument to compiled_cond, and add cases for compiled-condition Wei-cheng Wang
2015-06-30 9:57 ` Pedro Alves
2015-09-14 14:04 ` Pierre Langlois
2015-09-16 16:15 ` Yao Qi
2015-06-27 16:22 ` [PATCH 2/5 v4] powerpc: Support z-point type in gdbserver Wei-cheng Wang
2015-07-03 15:17 ` Ulrich Weigand
2016-02-24 12:05 ` Marcin Kościelnicki
2016-02-24 17:37 ` Ulrich Weigand
2016-02-24 17:39 ` Marcin Kościelnicki [this message]
2015-06-27 16:22 ` [PATCH 5/5 v4] Allow target to decide where to map jump-pad Wei-cheng Wang
2015-07-03 16:38 ` Ulrich Weigand
2015-06-27 16:22 ` [PATCH 4/5 v4] Tracepoint for ppc64 Wei-cheng Wang
2015-06-28 6:21 ` Wei-cheng Wang
2015-06-29 15:54 ` Pierre Langlois
2015-07-03 16:37 ` Ulrich Weigand
2015-06-30 9:57 ` [PATCH 1/5 v4] Remove tracepoint_action ops Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CDEAC0.5050905@0x04.net \
--to=koriakin@0x04.net \
--cc=cole945@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox