From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4920 invoked by alias); 24 Feb 2016 17:39:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4883 invoked by uid 89); 24 Feb 2016 17:39:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1588, UD:mi-dprintf.exp, mi-dprintf.exp, midprintfexp X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Feb 2016 17:39:15 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 4B3BC40000; Wed, 24 Feb 2016 18:40:07 +0100 (CET) Received: from [192.168.13.108] (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by hogfather.0x04.net (Postfix) with ESMTPSA id D90A1580100; Wed, 24 Feb 2016 18:39:12 +0100 (CET) Subject: Re: [PATCH 2/5 v4] powerpc: Support z-point type in gdbserver. To: Ulrich Weigand References: <20160224173657.740EF47F7@oc7340732750.ibm.com> Cc: Wei-cheng Wang , gdb-patches@sourceware.org From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56CDEAC0.5050905@0x04.net> Date: Wed, 24 Feb 2016 17:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160224173657.740EF47F7@oc7340732750.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00737.txt.bz2 On 24/02/16 18:36, Ulrich Weigand wrote: >> Another old approved patch that I'd like to push. Testing on >> ppc+ppc64+ppc64le: >> >> gdb.base/dprintf.exp: agent: 1st dprintf UNSUPPORTED -> PASS×3 >> gdb.base/jit.exp: PIE: one_jit_test-1: set var libname = >> "SHLIBDIR/jit-solib.so" PASS -> FAIL, on ppc64 only (I don't consider >> that one a problem, since jit.exp already has lots of similiar FAILs for >> this arch, nothing really new is broken here) >> gdb.mi/mi-dprintf.exp: mi expect stop FAIL×5 -> PASS×4 >> gdb.threads/forking-threads-plus-breakpoint.exp: cond_bp_target=1: >> detach_on_fork=on: displaced=off FAIL -> PASS×3 >> gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: >> cond_bp_target=1: KFAIL (memory error) -> KFAIL (prompt) >> gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: >> cond_bp_target=[01]: inferior 1 exited PASS×2 -> KFAIL (PRMS: gdb/18749) >> >> Fixes a lot of gdb.trace tests if I enable tracepoints. >> >> On 27/06/15 18:21, Wei-cheng Wang wrote: >>> Support z-point, so tracepoints and breakpoints can be inserted at the same >>> location. >>> >>> gdb/gdbserver/ChangeLog >>> >>> 2015-06-27 Wei-cheng Wang >>> >>> * linux-ppc-low.c (ppc_supports_z_point_type): New function: >>> (ppc_insert_point, ppc_remove_point): Insert/remove z-packet breakpoints. >>> (ppc64_emit_ops_vector): Add target ops - ppc_supports_z_point_type, >>> ppc_insert_point, ppc_remove_point. > > Yes, this is also still OK. > > Thanks, > Ulrich > Thanks, pushed.