From: Simon Marchi <simon.marchi@ericsson.com>
To: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] arm-tdep.c: Remove unsued "to" parameters
Date: Tue, 23 Feb 2016 15:54:00 -0000 [thread overview]
Message-ID: <56CC809A.4060200@ericsson.com> (raw)
In-Reply-To: <1456242724-5166-1-git-send-email-simon.marchi@ericsson.com>
On 16-02-23 10:52 AM, Simon Marchi wrote:
> gdb/ChangeLog:
>
> * arm-tdep.c (arm_decode_svc_copro): Remove "to" parameter.
> (thumb_process_displaced_insn): Likewise.
> (arm_process_displaced_insn): Adjust calls.
> ---
> gdb/arm-tdep.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
> index 1a3a209..17f6fc6 100644
> --- a/gdb/arm-tdep.c
> +++ b/gdb/arm-tdep.c
> @@ -6741,7 +6741,7 @@ thumb2_decode_ext_reg_ld_st (struct gdbarch *gdbarch, uint16_t insn1,
> }
>
> static int
> -arm_decode_svc_copro (struct gdbarch *gdbarch, uint32_t insn, CORE_ADDR to,
> +arm_decode_svc_copro (struct gdbarch *gdbarch, uint32_t insn,
> struct regcache *regs, struct displaced_step_closure *dsc)
> {
> unsigned int op1 = bits (insn, 20, 25);
> @@ -7446,7 +7446,7 @@ thumb_process_displaced_32bit_insn (struct gdbarch *gdbarch, uint16_t insn1,
>
> static void
> thumb_process_displaced_insn (struct gdbarch *gdbarch, CORE_ADDR from,
> - CORE_ADDR to, struct regcache *regs,
> + struct regcache *regs,
> struct displaced_step_closure *dsc)
> {
> enum bfd_endian byte_order_for_code = gdbarch_byte_order_for_code (gdbarch);
> @@ -7487,7 +7487,7 @@ arm_process_displaced_insn (struct gdbarch *gdbarch, CORE_ADDR from,
> dsc->wrote_to_pc = 0;
>
> if (!displaced_in_arm_mode (regs))
> - return thumb_process_displaced_insn (gdbarch, from, to, regs, dsc);
> + return thumb_process_displaced_insn (gdbarch, from, regs, dsc);
>
> dsc->is_thumb = 0;
> dsc->insn_size = 4;
> @@ -7518,7 +7518,7 @@ arm_process_displaced_insn (struct gdbarch *gdbarch, CORE_ADDR from,
> break;
>
> case 0xc: case 0xd: case 0xe: case 0xf:
> - err = arm_decode_svc_copro (gdbarch, insn, to, regs, dsc);
> + err = arm_decode_svc_copro (gdbarch, insn, regs, dsc);
> break;
> }
>
>
Obviously, s/unsued/unused/ in the subject line.
next prev parent reply other threads:[~2016-02-23 15:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 15:52 Simon Marchi
2016-02-23 15:54 ` Simon Marchi [this message]
2016-02-23 17:17 ` Yao Qi
2016-02-23 18:22 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC809A.4060200@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox