From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38554 invoked by alias); 23 Feb 2016 15:54:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38543 invoked by uid 89); 23 Feb 2016 15:54:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=uint16_t, 0xf, op1, 0xc X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 23 Feb 2016 15:54:21 +0000 Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id BD.A9.32102.1908CC65; Tue, 23 Feb 2016 16:53:53 +0100 (CET) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.89) with Microsoft SMTP Server id 14.3.248.2; Tue, 23 Feb 2016 10:54:02 -0500 Subject: Re: [PATCH] arm-tdep.c: Remove unsued "to" parameters To: References: <1456242724-5166-1-git-send-email-simon.marchi@ericsson.com> From: Simon Marchi Message-ID: <56CC809A.4060200@ericsson.com> Date: Tue, 23 Feb 2016 15:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1456242724-5166-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00690.txt.bz2 On 16-02-23 10:52 AM, Simon Marchi wrote: > gdb/ChangeLog: > > * arm-tdep.c (arm_decode_svc_copro): Remove "to" parameter. > (thumb_process_displaced_insn): Likewise. > (arm_process_displaced_insn): Adjust calls. > --- > gdb/arm-tdep.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index 1a3a209..17f6fc6 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -6741,7 +6741,7 @@ thumb2_decode_ext_reg_ld_st (struct gdbarch *gdbarch, uint16_t insn1, > } > > static int > -arm_decode_svc_copro (struct gdbarch *gdbarch, uint32_t insn, CORE_ADDR to, > +arm_decode_svc_copro (struct gdbarch *gdbarch, uint32_t insn, > struct regcache *regs, struct displaced_step_closure *dsc) > { > unsigned int op1 = bits (insn, 20, 25); > @@ -7446,7 +7446,7 @@ thumb_process_displaced_32bit_insn (struct gdbarch *gdbarch, uint16_t insn1, > > static void > thumb_process_displaced_insn (struct gdbarch *gdbarch, CORE_ADDR from, > - CORE_ADDR to, struct regcache *regs, > + struct regcache *regs, > struct displaced_step_closure *dsc) > { > enum bfd_endian byte_order_for_code = gdbarch_byte_order_for_code (gdbarch); > @@ -7487,7 +7487,7 @@ arm_process_displaced_insn (struct gdbarch *gdbarch, CORE_ADDR from, > dsc->wrote_to_pc = 0; > > if (!displaced_in_arm_mode (regs)) > - return thumb_process_displaced_insn (gdbarch, from, to, regs, dsc); > + return thumb_process_displaced_insn (gdbarch, from, regs, dsc); > > dsc->is_thumb = 0; > dsc->insn_size = 4; > @@ -7518,7 +7518,7 @@ arm_process_displaced_insn (struct gdbarch *gdbarch, CORE_ADDR from, > break; > > case 0xc: case 0xd: case 0xe: case 0xf: > - err = arm_decode_svc_copro (gdbarch, insn, to, regs, dsc); > + err = arm_decode_svc_copro (gdbarch, insn, regs, dsc); > break; > } > > Obviously, s/unsued/unused/ in the subject line.