Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Set breakpoint condition-evaluation in forking-threads-plus-breakpoint.exp
Date: Thu, 18 Feb 2016 11:25:00 -0000	[thread overview]
Message-ID: <56C5AA0D.4010903@redhat.com> (raw)
In-Reply-To: <1455793143-25234-1-git-send-email-yao.qi@linaro.org>

On 02/18/2016 10:59 AM, Yao Qi wrote:
> Proc do_test in forking-threads-plus-breakpoint.exp has an argument
> cond_bp_target, but the test doesn't use it to set
> "breakpoint condition-evaluation", which is an oversight in the test.

Whoops, indeed.

> 
> This patch fixes it by setting "breakpoint condition-evaluation" per
> $cond_bp_target.
> 
> gdb/testsuite:
> 
> 2016-02-18  Yao Qi  <yao.qi@linaro.org>
> 
> 	* gdb.threads/forking-threads-plus-breakpoint.exp (do_test):
> 	Set "set breakpoint condition-evaluation" per $cond_bp_target.

Thanks, LGTM.

Thanks,
Pedro Alves


  reply	other threads:[~2016-02-18 11:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 10:59 Yao Qi
2016-02-18 11:25 ` Pedro Alves [this message]
2016-02-18 12:05   ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C5AA0D.4010903@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox