From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23951 invoked by alias); 18 Feb 2016 11:25:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23939 invoked by uid 89); 18 Feb 2016 11:25:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=UD:gdb.threads, UD:threads, gdbthreads, gdb.threads X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 18 Feb 2016 11:25:04 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 36820C00EB11; Thu, 18 Feb 2016 11:25:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1IBP1Dk023561; Thu, 18 Feb 2016 06:25:02 -0500 Message-ID: <56C5AA0D.4010903@redhat.com> Date: Thu, 18 Feb 2016 11:25:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] Set breakpoint condition-evaluation in forking-threads-plus-breakpoint.exp References: <1455793143-25234-1-git-send-email-yao.qi@linaro.org> In-Reply-To: <1455793143-25234-1-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00533.txt.bz2 On 02/18/2016 10:59 AM, Yao Qi wrote: > Proc do_test in forking-threads-plus-breakpoint.exp has an argument > cond_bp_target, but the test doesn't use it to set > "breakpoint condition-evaluation", which is an oversight in the test. Whoops, indeed. > > This patch fixes it by setting "breakpoint condition-evaluation" per > $cond_bp_target. > > gdb/testsuite: > > 2016-02-18 Yao Qi > > * gdb.threads/forking-threads-plus-breakpoint.exp (do_test): > Set "set breakpoint condition-evaluation" per $cond_bp_target. Thanks, LGTM. Thanks, Pedro Alves