From: Simon Marchi <simon.marchi@ericsson.com>
To: "Marcin Kościelnicki" <koriakin@0x04.net>,
"Pedro Alves" <palves@redhat.com>,
"Sergio Durigan Junior" <sergiodj@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/3] gdb.trace: Save XML target description in tfile.
Date: Thu, 11 Feb 2016 19:02:00 -0000 [thread overview]
Message-ID: <56BCDABE.7080008@ericsson.com> (raw)
In-Reply-To: <56BBBB22.1050405@0x04.net>
On 16-02-10 05:35 PM, Marcin Kościelnicki wrote:
> On 10/02/16 23:20, Pedro Alves wrote:
>> On 02/10/2016 08:18 PM, Marcin Kościelnicki wrote:
>>> gdb/ChangeLog:
>>>
>>> * ctf.c (ctf_write_tdesc): New function.
>>> (ctf_write_ops): Wire in ctf_write_tdesc.
>>> * tracefile-tfile.c (tfile_write_tdesc): New function.
>>> (tfile_write_ops): Wire in tfile_write_tdesc.
>>> * tracefile.c (trace_save): Call write_tdesc method.
>>> * tracefile.h (struct trace_file_write_ops): Add write_tdesc method.
>>> * xml-tdesc.c (target_fetch_description_xml): New function.
>>> * xml-tdesc.h: Add target_fetch_description_xml prototype.
>>
>> OK.
>>
>> Thanks,
>> Pedro Alves
>>
>
> Thanks, pushed.
>
Hi Marcin,
Did you get an email from Builbot about this patch?
An unrelated patch did fail because of this one:
http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/3021/steps/compile%20gdb/logs/stdio
It happens when you build without expat. Maybe this particular slave doesn't have expat-devel
installed, but others do. You can reproduce it locally by configuring with --with-expat=no or
--without-expat.
@Sergio: To ensure that we always test in the same conditions, perhaps we could add --with-expat,
--with-python, and maybe others? Can it be done on a per-builder basis?
This way, if the slave for a builder is mis-configured (doesn't have development packages for
those), configure will fail right away. In an ideal world, to catch problems like the current
one though, we should test gdb (at least see if it builds) with various combinations of
with/without python, expat, etc.
next prev parent reply other threads:[~2016-02-11 19:02 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 15:39 [PATCH 0/4] Save " Marcin Kościelnicki
2016-02-06 15:39 ` [PATCH 2/4] gdb.trace: Read XML target description from tfile Marcin Kościelnicki
2016-02-10 13:02 ` Pedro Alves
2016-02-10 20:19 ` [PATCH 2/3] " Marcin Kościelnicki
2016-02-10 22:20 ` Pedro Alves
2016-02-10 22:35 ` Marcin Kościelnicki
2016-02-06 15:39 ` [PATCH 3/4] gdb.trace: Use g packet order in tfile_fetch_registers Marcin Kościelnicki
2016-02-10 13:20 ` Pedro Alves
2016-02-10 13:21 ` Marcin Kościelnicki
2016-02-10 13:54 ` Pedro Alves
2016-02-10 14:12 ` [PATCH] " Marcin Kościelnicki
2016-02-10 14:21 ` Pedro Alves
2016-02-10 14:49 ` Marcin Kościelnicki
2016-02-06 15:39 ` [PATCH 1/4] gdb.trace: Save XML target description in tfile Marcin Kościelnicki
2016-02-10 13:02 ` Pedro Alves
2016-02-10 20:18 ` [PATCH 1/3] " Marcin Kościelnicki
2016-02-10 22:20 ` Pedro Alves
2016-02-10 22:35 ` Marcin Kościelnicki
2016-02-11 19:02 ` Simon Marchi [this message]
2016-02-11 21:28 ` Sergio Durigan Junior
2016-02-11 22:31 ` Marcin Kościelnicki
2016-02-11 22:56 ` [PATCH] gdb: Fix build failure in xml-tdesc.c without expat Marcin Kościelnicki
2016-02-12 10:06 ` Pedro Alves
2016-02-12 10:10 ` Marcin Kościelnicki
2016-02-12 10:19 ` Pedro Alves
2016-02-12 10:21 ` Marcin Kościelnicki
2016-02-06 15:47 ` [PATCH 4/4] gdb.trace: Fix off-by-one in tfile_fetch_registers Marcin Kościelnicki
2016-02-10 13:22 ` Pedro Alves
2016-02-10 13:53 ` Marcin Kościelnicki
2016-02-06 20:54 ` [PATCH 5/6] gdb/x86: Implement ax_pseudo_register_collect hook Marcin Kościelnicki
2016-02-06 20:54 ` [PATCH 6/6] gdb.trace: Add a testcase for tdesc in tfile Marcin Kościelnicki
2016-02-10 13:50 ` Pedro Alves
2016-02-11 10:14 ` [PATCH] " Marcin Kościelnicki
2016-02-11 13:00 ` Pedro Alves
2016-02-11 14:17 ` Marcin Kościelnicki
2016-02-12 18:32 ` Antoine Tremblay
2016-02-12 18:40 ` Marcin Kościelnicki
2016-02-12 18:49 ` Antoine Tremblay
2016-02-12 18:53 ` Marcin Kościelnicki
2016-02-12 18:57 ` Antoine Tremblay
2016-02-12 19:47 ` [PATCH] gdb.trace/tfile-avx.c: Change ymm15 to xmm15 for old gcc Marcin Kościelnicki
2016-02-12 19:57 ` Pedro Alves
2016-02-12 21:34 ` Marcin Kościelnicki
2016-02-10 13:31 ` [PATCH 5/6] gdb/x86: Implement ax_pseudo_register_collect hook Pedro Alves
2016-02-10 13:34 ` Marcin Kościelnicki
2016-02-10 13:50 ` Pedro Alves
2016-02-10 14:27 ` [PATCH] " Marcin Kościelnicki
2016-02-10 14:28 ` Pedro Alves
2016-02-10 14:49 ` Marcin Kościelnicki
2016-02-10 14:24 ` [PATCH 0/4] Save target description in tfile Pedro Alves
2016-02-10 14:25 ` Marcin Kościelnicki
2016-02-10 20:19 ` [PATCH 3/3] gdb/doc: Add documentation for tfile description section lines Marcin Kościelnicki
2016-02-10 22:20 ` Pedro Alves
2016-02-17 9:50 ` Marcin Kościelnicki
2016-02-17 15:37 ` Pedro Alves
2016-02-17 15:38 ` Pedro Alves
2016-02-17 15:59 ` Eli Zaretskii
2016-02-17 16:04 ` Marcin Kościelnicki
2016-02-17 16:05 ` Pedro Alves
2016-02-18 8:28 ` Marcin Kościelnicki
2016-02-11 17:36 ` [PATCH 0/4] Save target description in tfile Yao Qi
2016-02-12 1:49 ` Marcin Kościelnicki
2016-02-12 12:13 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BCDABE.7080008@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=koriakin@0x04.net \
--cc=palves@redhat.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox