From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34356 invoked by alias); 11 Feb 2016 19:02:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34343 invoked by uid 89); 11 Feb 2016 19:02:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=160210, misconfigured X-HELO: usplmg20.ericsson.net Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 11 Feb 2016 19:02:25 +0000 Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78]) by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id E0.D8.12433.237DCB65; Thu, 11 Feb 2016 19:47:15 +0100 (CET) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.80) with Microsoft SMTP Server id 14.3.248.2; Thu, 11 Feb 2016 14:02:22 -0500 Subject: Re: [PATCH 1/3] gdb.trace: Save XML target description in tfile. To: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= , Pedro Alves , Sergio Durigan Junior References: <56BB34F2.5030403@redhat.com> <1455135521-21767-1-git-send-email-koriakin@0x04.net> <56BBB793.3080108@redhat.com> <56BBBB22.1050405@0x04.net> CC: From: Simon Marchi Message-ID: <56BCDABE.7080008@ericsson.com> Date: Thu, 11 Feb 2016 19:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56BBBB22.1050405@0x04.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00385.txt.bz2 On 16-02-10 05:35 PM, Marcin Ko=C5=9Bcielnicki wrote: > On 10/02/16 23:20, Pedro Alves wrote: >> On 02/10/2016 08:18 PM, Marcin Ko=C5=9Bcielnicki wrote: >>> gdb/ChangeLog: >>> >>> * ctf.c (ctf_write_tdesc): New function. >>> (ctf_write_ops): Wire in ctf_write_tdesc. >>> * tracefile-tfile.c (tfile_write_tdesc): New function. >>> (tfile_write_ops): Wire in tfile_write_tdesc. >>> * tracefile.c (trace_save): Call write_tdesc method. >>> * tracefile.h (struct trace_file_write_ops): Add write_tdesc method. >>> * xml-tdesc.c (target_fetch_description_xml): New function. >>> * xml-tdesc.h: Add target_fetch_description_xml prototype. >> >> OK. >> >> Thanks, >> Pedro Alves >> >=20 > Thanks, pushed. >=20 Hi Marcin, Did you get an email from Builbot about this patch? An unrelated patch did fail because of this one: http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/3021/steps/compil= e%20gdb/logs/stdio It happens when you build without expat. Maybe this particular slave doesn= 't have expat-devel installed, but others do. You can reproduce it locally by configuring with= --with-expat=3Dno or --without-expat. @Sergio: To ensure that we always test in the same conditions, perhaps we c= ould add --with-expat, --with-python, and maybe others? Can it be done on a per-builder basis? This way, if the slave for a builder is mis-configured (doesn't have develo= pment packages for those), configure will fail right away. In an ideal world, to catch proble= ms like the current one though, we should test gdb (at least see if it builds) with various com= binations of with/without python, expat, etc.