From: Pedro Alves <palves@redhat.com>
To: Zachary T Welch <zwelch@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] GDB testsuite: Escape paths used in regular expressions
Date: Wed, 10 Feb 2016 16:46:00 -0000 [thread overview]
Message-ID: <56BB6967.4070503@redhat.com> (raw)
In-Reply-To: <1455122399-31551-1-git-send-email-zwelch@codesourcery.com>
On 02/10/2016 04:39 PM, Zachary T Welch wrote:
> This patch fixes problems with a few GDB testsuites when executing in a
> path that contains special characters (e.g. "++"). When such paths are
> used as a regular expression, the regular expression parser will choke
> and cause the tests to fail. This patch introduces a new function to
> escape strings that will be used as regular expressions, using it to
> sanitize path names used in expect scripts.
>
> If it looks good, please commit. Thanks!
>
> gdb/testsuite/:
> * gdb.base/maint.exp: Escape paths used in regular expressions.
> * gdb.stabs/weird.exp: Likewise.
> * gdb.exp (escape_regex_chars): New.
Seems like you reinvented string_to_regexp.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-02-10 16:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 16:40 Zachary T Welch
2016-02-10 16:46 ` Pedro Alves [this message]
2016-02-10 17:47 ` [PATCH v2] " Zachary T Welch
2016-02-10 17:53 ` Pedro Alves
2016-07-12 22:28 ` Don Breazeal
2016-07-15 13:34 ` Yao Qi
2016-07-15 18:24 ` [pushed] " Don Breazeal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BB6967.4070503@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=zwelch@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox