From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34056 invoked by alias); 10 Feb 2016 16:46:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34034 invoked by uid 89); 10 Feb 2016 16:46:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=escape X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Feb 2016 16:46:34 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id C034C37C36C; Wed, 10 Feb 2016 16:46:32 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1AGkVU7009212; Wed, 10 Feb 2016 11:46:31 -0500 Message-ID: <56BB6967.4070503@redhat.com> Date: Wed, 10 Feb 2016 16:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Zachary T Welch , gdb-patches@sourceware.org Subject: Re: [PATCH] GDB testsuite: Escape paths used in regular expressions References: <1455122399-31551-1-git-send-email-zwelch@codesourcery.com> In-Reply-To: <1455122399-31551-1-git-send-email-zwelch@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00306.txt.bz2 On 02/10/2016 04:39 PM, Zachary T Welch wrote: > This patch fixes problems with a few GDB testsuites when executing in a > path that contains special characters (e.g. "++"). When such paths are > used as a regular expression, the regular expression parser will choke > and cause the tests to fail. This patch introduces a new function to > escape strings that will be used as regular expressions, using it to > sanitize path names used in expect scripts. > > If it looks good, please commit. Thanks! > > gdb/testsuite/: > * gdb.base/maint.exp: Escape paths used in regular expressions. > * gdb.stabs/weird.exp: Likewise. > * gdb.exp (escape_regex_chars): New. Seems like you reinvented string_to_regexp. Thanks, Pedro Alves