Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Keith Seitz <keiths@redhat.com>,
	Joel Brobecker <brobecker@adacore.com>,
	       "gdb-patches@sourceware.org ml"
	<gdb-patches@sourceware.org>
Subject: Re: RFC: branching for GDB 7.11 soon? (possibly Wed)
Date: Mon, 08 Feb 2016 20:06:00 -0000	[thread overview]
Message-ID: <56B8F550.4020506@redhat.com> (raw)
In-Reply-To: <56B8EC41.7080004@redhat.com>

On 02/08/2016 07:28 PM, Keith Seitz wrote:

> I looked at this over the weekend and updated the bz. It seems pretty
> trivial, and the patch is very safe to use.
> 
> In short, update_breakpoints_after_exec is charged with deleting any
> breakpoint with no location. momentary_breakpoint types were implemented
> to rely on this behavior. So b->location can be NULL, contrary to what I
> previously assumed.
> 
> Simply handling NULL in location_empty_p fixes this.
> 
> Writing a test for this now.

Thanks Keith.  Having the testsuite cover this would be great.

BTW, calling both b->location and the b->loc things "locations"
is ambiguous and confusing, IMO.  How about we start calling
the new b->location, the "location spec" ?

Thanks,
Pedro Alves


  reply	other threads:[~2016-02-08 20:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01  3:06 Joel Brobecker
2016-02-01 13:34 ` Pedro Alves
2016-02-01 17:04   ` Pedro Alves
2016-02-01 19:51 ` Keith Seitz
2016-02-04  0:45   ` [RFC] breakpoints/19474 [was Re: RFC: branching for GDB 7.11 soon? (possibly Wed)] Keith Seitz
2016-02-04  1:33     ` Keith Seitz
2016-02-04 11:05     ` Yao Qi
2016-02-04 12:31     ` Pedro Alves
2016-08-12 12:00       ` Yao Qi
2016-02-07  8:12 ` RFC: branching for GDB 7.11 soon? (possibly Wed) Joel Brobecker
2016-02-08 18:03   ` Sergio Durigan Junior
2016-02-08 19:28   ` Keith Seitz
2016-02-08 20:06     ` Pedro Alves [this message]
2016-02-08 20:11       ` Keith Seitz
2016-02-09  5:35   ` Sergio Durigan Junior
2016-02-09 14:15     ` Simon Marchi
2016-02-09 14:18       ` Pedro Alves
2016-02-09 14:52         ` Simon Marchi
2016-02-09 18:31           ` Sergio Durigan Junior
2016-02-09 11:56   ` Joel Brobecker
2016-02-09 12:37     ` Pedro Alves
2016-02-09 22:37       ` Keith Seitz
2016-02-10  3:40     ` Joel Brobecker
2016-02-10 10:04       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B8F550.4020506@redhat.com \
    --to=palves@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox