From: Pedro Alves <palves@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>,
Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Introduce skip_to_char and use it
Date: Wed, 27 Jan 2016 11:22:00 -0000 [thread overview]
Message-ID: <56A8A855.8050208@redhat.com> (raw)
In-Reply-To: <878u3b24f8.fsf@redhat.com>
On 01/27/2016 01:32 AM, Sergio Durigan Junior wrote:
> The problem with skip_to_char IMO is that it leads the reader to believe
> that this function performs the same job as strchr (in fact, my first
> reaction when I read this introduction was to think "why not use
> strchr?"). The main difference, however, is that this function actually
> skips everything if the char was not found.
>
> I believe a name like "skip_to_char_or_nul" may be more appropriate.
> What do you think?
That sounds just like strchrnul, though. It's not available everywhere,
but, gnulib has a strchrnul module that fixes that.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-01-27 11:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 21:54 Simon Marchi
2016-01-27 1:32 ` Sergio Durigan Junior
2016-01-27 11:22 ` Pedro Alves [this message]
2016-01-27 11:53 ` Andreas Schwab
2016-01-27 18:04 ` Sergio Durigan Junior
2016-01-27 18:27 ` Simon Marchi
2016-01-27 21:04 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A8A855.8050208@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox