From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102401 invoked by alias); 27 Jan 2016 11:22:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102384 invoked by uid 89); 27 Jan 2016 11:22:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=junior, Junior X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 Jan 2016 11:22:00 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 23DF1219D; Wed, 27 Jan 2016 11:21:59 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0RBLvv9010684; Wed, 27 Jan 2016 06:21:58 -0500 Message-ID: <56A8A855.8050208@redhat.com> Date: Wed, 27 Jan 2016 11:22:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Sergio Durigan Junior , Simon Marchi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Introduce skip_to_char and use it References: <1453845250-30360-1-git-send-email-simon.marchi@ericsson.com> <878u3b24f8.fsf@redhat.com> In-Reply-To: <878u3b24f8.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00668.txt.bz2 On 01/27/2016 01:32 AM, Sergio Durigan Junior wrote: > The problem with skip_to_char IMO is that it leads the reader to believe > that this function performs the same job as strchr (in fact, my first > reaction when I read this introduction was to think "why not use > strchr?"). The main difference, however, is that this function actually > skips everything if the char was not found. > > I believe a name like "skip_to_char_or_nul" may be more appropriate. > What do you think? That sounds just like strchrnul, though. It's not available everywhere, but, gnulib has a strchrnul module that fixes that. Thanks, Pedro Alves