From: Pedro Alves <palves@redhat.com>
To: Mark Wielaard <mjw@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix GCC6 -Wmisleading-indentation issues.
Date: Mon, 25 Jan 2016 23:00:00 -0000 [thread overview]
Message-ID: <56A6A8EF.8010709@redhat.com> (raw)
In-Reply-To: <20160125223805.GB2721@blokker.redhat.com>
On 01/25/2016 10:38 PM, Mark Wielaard wrote:
> On Mon, Jan 25, 2016 at 10:24:45PM +0000, Pedro Alves wrote:
>> Yeah... It was part being lazy and port not wanting to mess git blame for
>> such old code much. There's an easy way around it though. Add an
>> else, like:
>>
>> if (tinfo->run_terminal != NULL || gdb_has_a_terminal () == 0)
>> return;
>> + else
>> {
>
> O, very nice. I did it that way and adjusted commit message and ChangeLog.
>
> OK to commit?
OK.
Thanks,
Pedro Alves
prev parent reply other threads:[~2016-01-25 23:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 19:41 Mark Wielaard
2016-01-25 21:46 ` Simon Marchi
2016-01-25 22:14 ` Mark Wielaard
2016-01-25 22:24 ` Pedro Alves
2016-01-25 22:38 ` Mark Wielaard
2016-01-25 23:00 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A6A8EF.8010709@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mjw@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox