From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-129019-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1757 invoked by alias); 25 Jan 2016 23:00:14 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 392 invoked by uid 89); 25 Jan 2016 23:00:03 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 25 Jan 2016 23:00:02 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (Postfix) with ESMTPS id 97D517AE8B;	Mon, 25 Jan 2016 23:00:01 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0PMxxv3019515;	Mon, 25 Jan 2016 18:00:00 -0500
Message-ID: <56A6A8EF.8010709@redhat.com>
Date: Mon, 25 Jan 2016 23:00:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Mark Wielaard <mjw@redhat.com>
CC: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix GCC6 -Wmisleading-indentation issues.
References: <1453750851-29990-1-git-send-email-mjw@redhat.com> <56A697A2.9060207@ericsson.com> <20160125221411.GA2721@blokker.redhat.com> <56A6A0AD.1090901@redhat.com> <20160125223805.GB2721@blokker.redhat.com>
In-Reply-To: <20160125223805.GB2721@blokker.redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-01/txt/msg00640.txt.bz2

On 01/25/2016 10:38 PM, Mark Wielaard wrote:
> On Mon, Jan 25, 2016 at 10:24:45PM +0000, Pedro Alves wrote:
>> Yeah...  It was part being lazy and port not wanting to mess git blame for
>> such old code much.  There's an easy way around it though.  Add an
>> else, like:
>>
>>   if (tinfo->run_terminal != NULL || gdb_has_a_terminal () == 0)
>>     return;
>> + else
>>     {
> 
> O, very nice. I did it that way and adjusted commit message and ChangeLog.
> 
> OK to commit?

OK.

Thanks,
Pedro Alves