[PATCH] Remove new_thread_notify and dead_thread_notify

[PATCH] Remove new_thread_notify and dead_thread_notify

[Yao Qi]

They were added by

  PATCH: Multithreaded debugging for gdbserver
  https://sourceware.org/ml/gdb-patches/2002-06/msg00157.html

but as a no-op, and the last usage of them was removed by

  [gdbserver/RFC/RFA] Implement multiprocess extensions, add linux multiproces support.
  https://sourceware.org/ml/gdb-patches/2009-03/msg00667.html

This patch is to remove them.  Didn't run regression test because this
patch removes dead code.

gdb/gdbserver:

2016-01-25  Yao Qi  <yao.qi@linaro.org>

	* remote-utils.c (new_thread_notify): Remove.
	(dead_thread_notify): Likewise.
	* remote-utils.h (new_thread_notify): Remove declaration.
	(dead_thread_notify): Likewise.
---
 gdb/gdbserver/remote-utils.c | 33 ---------------------------------
 gdb/gdbserver/remote-utils.h |  2 --
 2 files changed, 35 deletions(-)

diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c
index 15cdbe1..292197a 100644
--- a/gdb/gdbserver/remote-utils.c
+++ b/gdb/gdbserver/remote-utils.c
@@ -1084,39 +1084,6 @@ outreg (struct regcache *regcache, int regno, char *buf)
 }
 
 void
-new_thread_notify (int id)
-{
-  char own_buf[256];
-
-  /* The `n' response is not yet part of the remote protocol.  Do nothing.  */
-  if (1)
-    return;
-
-  if (server_waiting == 0)
-    return;
-
-  sprintf (own_buf, "n%x", id);
-  disable_async_io ();
-  putpkt (own_buf);
-  enable_async_io ();
-}
-
-void
-dead_thread_notify (int id)
-{
-  char own_buf[256];
-
-  /* The `x' response is not yet part of the remote protocol.  Do nothing.  */
-  if (1)
-    return;
-
-  sprintf (own_buf, "x%x", id);
-  disable_async_io ();
-  putpkt (own_buf);
-  enable_async_io ();
-}
-
-void
 prepare_resume_reply (char *buf, ptid_t ptid,
 		      struct target_waitstatus *status)
 {
diff --git a/gdb/gdbserver/remote-utils.h b/gdb/gdbserver/remote-utils.h
index 32933f5..2ddf590 100644
--- a/gdb/gdbserver/remote-utils.h
+++ b/gdb/gdbserver/remote-utils.h
@@ -44,8 +44,6 @@ void initialize_async_io (void);
 void enable_async_io (void);
 void disable_async_io (void);
 void check_remote_input_interrupt_request (void);
-void new_thread_notify (int id);
-void dead_thread_notify (int id);
 void prepare_resume_reply (char *buf, ptid_t ptid,
 			   struct target_waitstatus *status);
 
-- 
1.9.1

Re: [PATCH] Remove new_thread_notify and dead_thread_notify

[Pedro Alves]

On 01/25/2016 12:32 PM, Yao Qi wrote:
> They were added by
> 
>   PATCH: Multithreaded debugging for gdbserver
>   https://sourceware.org/ml/gdb-patches/2002-06/msg00157.html
> 
> but as a no-op, and the last usage of them was removed by
> 
>   [gdbserver/RFC/RFA] Implement multiprocess extensions, add linux multiproces support.
>   https://sourceware.org/ml/gdb-patches/2009-03/msg00667.html
> 
> This patch is to remove them.  Didn't run regression test because this
> patch removes dead code.

Yeah, I think these functions were always dead anyway.  ("if (1) return;")

OK.

Thanks,
Pedro Alves

Re: [PATCH] Remove new_thread_notify and dead_thread_notify

[Yao Qi]

Pedro Alves <palves@redhat.com> writes:

> Yeah, I think these functions were always dead anyway.  ("if (1) return;")

Thanks, patch is pushed in.

-- 
Yao (齐尧)