From: Pedro Alves <pedro@palves.net>
To: "Marcin Kościelnicki" <koriakin@0x04.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb.trace: Fix unavailable-dwarf-piece.exp on big endian targets
Date: Sat, 23 Jan 2016 13:22:00 -0000 [thread overview]
Message-ID: <56A37E99.9080203@palves.net> (raw)
In-Reply-To: <1453552454-18078-1-git-send-email-koriakin@0x04.net>
On 01/23/2016 12:34 PM, Marcin Kościelnicki wrote:
> diff --git a/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp b/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp
> index 60820dd..e511915 100644
> --- a/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp
> +++ b/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp
> @@ -325,10 +325,23 @@ with_test_prefix "tracing bar" {
> gdb_test "continue" "Continuing\\.\[ \r\n\]+Breakpoint.*"
> gdb_test_no_output "tstop"
>
> + gdb_test_multiple "show endian" "show endian" {
> + -re ".* (big|little) endian.*$gdb_prompt $" {
> + set endian $expect_out(1,string)
> + pass "endianness: $endian"
> + }
> + }
Do:
set endian ""
gdb_test_multiple "show endian" "show endian" {
...
Otherwise if that gdb_test_multiple fails, $endian doesn't exist,
and the if below throws a tcl error.
OK with that change.
next prev parent reply other threads:[~2016-01-23 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 12:34 Marcin Kościelnicki
2016-01-23 13:22 ` Pedro Alves [this message]
2016-01-23 13:59 ` Marcin Kościelnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A37E99.9080203@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=koriakin@0x04.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox