From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51975 invoked by alias); 23 Jan 2016 13:22:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51959 invoked by uid 89); 23 Jan 2016 13:22:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:933, HContent-Transfer-Encoding:8bit X-HELO: mail-wm0-f41.google.com Received: from mail-wm0-f41.google.com (HELO mail-wm0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 23 Jan 2016 13:22:39 +0000 Received: by mail-wm0-f41.google.com with SMTP id l65so15153662wmf.1 for ; Sat, 23 Jan 2016 05:22:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=1/39VDl/1fArTRAiJvJ6gmKOOgiDuYQosjah4RdwiZo=; b=iHypqxBSHTRExHjh2P2xxFta7hjZzao08j0voLYFjAYY+a/KtSnP2qzoUERZe3v35Y fnH5OYnDcqJEJxDoz/kENY3Ke4FmbtYAH5EyeeQ3vzdpBitNdbSw2Ua7rtxDNVfbd6rF R6fnmgPLaVp/0pmDNJwWlJe9EzII9XI6M9DM7WpikF4goJuXe0oyBqgCfD6Nb/LoskE7 zOW5kAoUImfOZeUjBCZQRJTXK/+slGCra4YbwHFPBvanJEZSEz1aaPjk9IIqqNloxYYF b1mQd2MvZJJA7qYkZgmzNgE2ig3QxO4Lqjho7YeDmpowG0VWj8m2HTtcYyQSii6Hi9OV +6yg== X-Gm-Message-State: AG10YOS+kjHoNha3HiSI1CrvS65gCDj47PwGPCm+tJ3IlBAZHXyBxT9Id/eIRbtVhES1zg== X-Received: by 10.194.21.135 with SMTP id v7mr8137460wje.131.1453555356820; Sat, 23 Jan 2016 05:22:36 -0800 (PST) Received: from ?IPv6:2001:8a0:f91e:8801:2677:3ff:fe1e:aba4? ([2001:8a0:f91e:8801:2677:3ff:fe1e:aba4]) by smtp.googlemail.com with ESMTPSA id v2sm7312391wmv.12.2016.01.23.05.22.34 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 23 Jan 2016 05:22:34 -0800 (PST) Message-ID: <56A37E99.9080203@palves.net> Date: Sat, 23 Jan 2016 13:22:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb.trace: Fix unavailable-dwarf-piece.exp on big endian targets References: <1453552454-18078-1-git-send-email-koriakin@0x04.net> In-Reply-To: <1453552454-18078-1-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00594.txt.bz2 On 01/23/2016 12:34 PM, Marcin Kościelnicki wrote: > diff --git a/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp b/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp > index 60820dd..e511915 100644 > --- a/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp > +++ b/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp > @@ -325,10 +325,23 @@ with_test_prefix "tracing bar" { > gdb_test "continue" "Continuing\\.\[ \r\n\]+Breakpoint.*" > gdb_test_no_output "tstop" > > + gdb_test_multiple "show endian" "show endian" { > + -re ".* (big|little) endian.*$gdb_prompt $" { > + set endian $expect_out(1,string) > + pass "endianness: $endian" > + } > + } Do: set endian "" gdb_test_multiple "show endian" "show endian" { ... Otherwise if that gdb_test_multiple fails, $endian doesn't exist, and the if below throws a tcl error. OK with that change.