From: Pedro Alves <palves@redhat.com>
To: "Marcin Kościelnicki" <koriakin@0x04.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdb.trace: Fix string collection for 64-bit platforms.
Date: Thu, 21 Jan 2016 16:55:00 -0000 [thread overview]
Message-ID: <56A10D73.9030505@redhat.com> (raw)
In-Reply-To: <1453394591-5181-1-git-send-email-koriakin@0x04.net>
On 01/21/2016 04:43 PM, Marcin Kościelnicki wrote:
> String collection always used ref32 to fetch the string pointer. Make it
> use gen_fetch instead.
>
> As a side effect, this patch changes dup+const+trace+pop sequence used
> for collecting the string's address to a trace_quick opcode. This
> results in a shorter agent expression.
>
> This appeared to work on x86_64 since it's a little-endian platform, and
> malloc (used in gdb.trace/collection.exp) returns addresses in low 4GB.
> Noticed and tested on s390x-ibm-linux-gnu, also tested on
> i686-unknown-linux-gnu and x86_64-unknown-linux-gnu.
>
> gdb/ChangeLog:
>
> * ax-gdb.c (gen_traced_pop): Use gen_fetch for string collection.
> ---
> Instead of factoring out the switch, I just delegated to gen_fetch.
> Turns out we can shave off a few ops this way, too. Likewise tested
> on s390, s390x, i686, x86_64.
Even better. This is OK.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-01-21 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 16:02 [PATCH] " Marcin Kościelnicki
2016-01-21 16:14 ` Pedro Alves
2016-01-21 16:18 ` Marcin Kościelnicki
2016-01-21 16:43 ` [PATCH v2] " Marcin Kościelnicki
2016-01-21 16:55 ` Pedro Alves [this message]
2016-01-21 18:51 ` Marcin Kościelnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A10D73.9030505@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=koriakin@0x04.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox