From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40836 invoked by alias); 21 Jan 2016 16:55:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40766 invoked by uid 89); 21 Jan 2016 16:55:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=agent, collecting, UD:collection.exp, collectionexp X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 Jan 2016 16:55:18 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 68594120496; Thu, 21 Jan 2016 16:55:17 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0LGtFXW015813; Thu, 21 Jan 2016 11:55:16 -0500 Message-ID: <56A10D73.9030505@redhat.com> Date: Thu, 21 Jan 2016 16:55:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb.trace: Fix string collection for 64-bit platforms. References: <56A103D5.2090505@redhat.com> <1453394591-5181-1-git-send-email-koriakin@0x04.net> In-Reply-To: <1453394591-5181-1-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-01/txt/msg00542.txt.bz2 On 01/21/2016 04:43 PM, Marcin Kościelnicki wrote: > String collection always used ref32 to fetch the string pointer. Make it > use gen_fetch instead. > > As a side effect, this patch changes dup+const+trace+pop sequence used > for collecting the string's address to a trace_quick opcode. This > results in a shorter agent expression. > > This appeared to work on x86_64 since it's a little-endian platform, and > malloc (used in gdb.trace/collection.exp) returns addresses in low 4GB. > Noticed and tested on s390x-ibm-linux-gnu, also tested on > i686-unknown-linux-gnu and x86_64-unknown-linux-gnu. > > gdb/ChangeLog: > > * ax-gdb.c (gen_traced_pop): Use gen_fetch for string collection. > --- > Instead of factoring out the switch, I just delegated to gen_fetch. > Turns out we can shave off a few ops this way, too. Likewise tested > on s390, s390x, i686, x86_64. Even better. This is OK. Thanks, Pedro Alves