Re: [PATCH] testsuite: Make check-parallel return non-zero if a test failed

[Pedro Alves <palves@redhat.com>]

On 01/18/2016 10:48 PM, Simon Marchi wrote:
> When using the check-parallel target, the return code of make is always 0,
> regardless of test results.  This patch makes it return the same code as
> the "make do-check-parallel" sub-command.  So if there is a FAIL somewhere,
> non-zero will be returned by make.
> 
> For the sake of example, I introduced a failure in gdb.base/break.exp.
> 
>   $ make check-single TESTS="gdb.base/break.exp gdb.python/py-value.exp" && echo 'Success :D' || echo 'Fail :('
>   ...
>   FAIL: gdb.base/break.exp: allo
>   ...
>   Fail :(
> 
> I think the parallel run should do the same.  Currently:
> 
>   $ make check-parallel TESTS="gdb.base/break.exp gdb.python/py-value.exp" && echo 'Success :D' || echo 'Fail :('
>   ...
>   FAIL: gdb.base/break.exp: allo
>   ...
>   Success :D
> 
> And with the patch (no big surprises there):
> 
>   $ make check-parallel TESTS="gdb.base/break.exp gdb.python/py-value.exp" && echo 'Success :D' || echo 'Fail :('
>   ...
>   FAIL: gdb.base/break.exp: allo
>   ...
>   Fail :(
> 
> What do you think?

This has occasionally annoyed me too.  Thanks for fixing this!

LGTM.

Thanks,
Pedro Alves