From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8625 invoked by alias); 19 Jan 2016 11:15:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8609 invoked by uid 89); 19 Jan 2016 11:15:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 19 Jan 2016 11:15:44 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id A197B18B249; Tue, 19 Jan 2016 11:15:42 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0JBFfPo021717; Tue, 19 Jan 2016 06:15:41 -0500 Message-ID: <569E1ADD.9010808@redhat.com> Date: Tue, 19 Jan 2016 11:15:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] testsuite: Make check-parallel return non-zero if a test failed References: <1453157331-5472-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1453157331-5472-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00419.txt.bz2 On 01/18/2016 10:48 PM, Simon Marchi wrote: > When using the check-parallel target, the return code of make is always 0, > regardless of test results. This patch makes it return the same code as > the "make do-check-parallel" sub-command. So if there is a FAIL somewhere, > non-zero will be returned by make. > > For the sake of example, I introduced a failure in gdb.base/break.exp. > > $ make check-single TESTS="gdb.base/break.exp gdb.python/py-value.exp" && echo 'Success :D' || echo 'Fail :(' > ... > FAIL: gdb.base/break.exp: allo > ... > Fail :( > > I think the parallel run should do the same. Currently: > > $ make check-parallel TESTS="gdb.base/break.exp gdb.python/py-value.exp" && echo 'Success :D' || echo 'Fail :(' > ... > FAIL: gdb.base/break.exp: allo > ... > Success :D > > And with the patch (no big surprises there): > > $ make check-parallel TESTS="gdb.base/break.exp gdb.python/py-value.exp" && echo 'Success :D' || echo 'Fail :(' > ... > FAIL: gdb.base/break.exp: allo > ... > Fail :( > > What do you think? This has occasionally annoyed me too. Thanks for fixing this! LGTM. Thanks, Pedro Alves