Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC/commmit] [testsuite/Ada] stop using project files when building test programs
Date: Wed, 23 Dec 2015 15:30:00 -0000	[thread overview]
Message-ID: <567ABE09.9070405@redhat.com> (raw)
In-Reply-To: <567ABC0C.3040204@redhat.com>

On 12/23/2015 03:21 PM, Pedro Alves wrote:
>> > --- a/gdb/testsuite/gdb.ada/cond_lang.exp
>> > +++ b/gdb/testsuite/gdb.ada/cond_lang.exp
>> > @@ -39,7 +39,7 @@ gdb_test "show lang" \
>> >  # current language mode is auto, and the breakpoint is inside Ada code.
>> >  set bp_location [gdb_get_line_number "STOP" ${testdir}/mixed.adb]
>> >  gdb_test "break mixed.adb:${bp_location} if light = green" \
>> > -         "Breakpoint \[0-9\]* at .*: file .*/mixed.adb, line \[0-9\]*\\."
>> > +         "Breakpoint \[0-9\]* at .*: file (.*/)?mixed.adb, line \[0-9\]*\\."
> Isn't that the same as just:
> 
>  -         "Breakpoint \[0-9\]* at .*: file .*/mixed.adb, line \[0-9\]*\\."
>  +         "Breakpoint \[0-9\]* at .*: file .*mixed.adb, line \[0-9\]*\\."
> 
> ?
> 

Huh, sorry, brain malfunction.  My version would give out a spurious
PASS with foomixed.adb, yours wouldn't.

>> >  gdb_test "continue" \
>> > -    "Breakpoint .*, pck\\.call_me \\(w=(w@entry=)?50\\) at .*/pck.adb:.*" \
>> > +    "Breakpoint .*, pck\\.call_me \\(w=(w@entry=)?50\\) at (.*)?/pck.adb:.*" \
>> >      "continue to call_me"
> Likewise, I think this is a no-op.  Did you mean to put the / inside the
> parens like in the other case?  If so I'd suggest:

This one still looks odd to me, though.

Thanks,
Pedro Alves


  reply	other threads:[~2015-12-23 15:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-22 15:33 Joel Brobecker
2015-12-23 13:21 ` Pedro Alves
2015-12-23 13:35   ` Joel Brobecker
2015-12-23 14:43     ` Joel Brobecker
2015-12-23 15:21       ` Pedro Alves
2015-12-23 15:30         ` Pedro Alves [this message]
2015-12-24  5:30           ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=567ABE09.9070405@redhat.com \
    --to=palves@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox