From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57376 invoked by alias); 23 Dec 2015 15:30:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57365 invoked by uid 89); 23 Dec 2015 15:30:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=UD:gdb.ada, gdb.ada, gdbada, UD:ada X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 23 Dec 2015 15:30:20 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 7BB05C077527; Wed, 23 Dec 2015 15:30:19 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBNFUIiK004324; Wed, 23 Dec 2015 10:30:18 -0500 Message-ID: <567ABE09.9070405@redhat.com> Date: Wed, 23 Dec 2015 15:30:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [RFC/commmit] [testsuite/Ada] stop using project files when building test programs References: <1450798411-26617-1-git-send-email-brobecker@adacore.com> <567A9FE6.30504@redhat.com> <20151223133504.GB18676@adacore.com> <20151223144303.GC18676@adacore.com> <567ABC0C.3040204@redhat.com> In-Reply-To: <567ABC0C.3040204@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00469.txt.bz2 On 12/23/2015 03:21 PM, Pedro Alves wrote: >> > --- a/gdb/testsuite/gdb.ada/cond_lang.exp >> > +++ b/gdb/testsuite/gdb.ada/cond_lang.exp >> > @@ -39,7 +39,7 @@ gdb_test "show lang" \ >> > # current language mode is auto, and the breakpoint is inside Ada code. >> > set bp_location [gdb_get_line_number "STOP" ${testdir}/mixed.adb] >> > gdb_test "break mixed.adb:${bp_location} if light = green" \ >> > - "Breakpoint \[0-9\]* at .*: file .*/mixed.adb, line \[0-9\]*\\." >> > + "Breakpoint \[0-9\]* at .*: file (.*/)?mixed.adb, line \[0-9\]*\\." > Isn't that the same as just: > > - "Breakpoint \[0-9\]* at .*: file .*/mixed.adb, line \[0-9\]*\\." > + "Breakpoint \[0-9\]* at .*: file .*mixed.adb, line \[0-9\]*\\." > > ? > Huh, sorry, brain malfunction. My version would give out a spurious PASS with foomixed.adb, yours wouldn't. >> > gdb_test "continue" \ >> > - "Breakpoint .*, pck\\.call_me \\(w=(w@entry=)?50\\) at .*/pck.adb:.*" \ >> > + "Breakpoint .*, pck\\.call_me \\(w=(w@entry=)?50\\) at (.*)?/pck.adb:.*" \ >> > "continue to call_me" > Likewise, I think this is a no-op. Did you mean to put the / inside the > parens like in the other case? If so I'd suggest: This one still looks odd to me, though. Thanks, Pedro Alves