From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix -Wno-unknown-warning support detection
Date: Wed, 16 Dec 2015 23:13:00 -0000 [thread overview]
Message-ID: <5671F01F.1070307@redhat.com> (raw)
In-Reply-To: <5671EECA.4080206@ericsson.com>
On 12/16/2015 11:07 PM, Simon Marchi wrote:
> It looks good.
I pushed it, thanks.
Note that you could have done
>
> wtest=`echo $w | sed 's/-Wno-/-W/g'`
>
> unconditionally. If it doesn't match, it won't replace anything:
>
> $ echo -Wlol | sed 's/-Wno-/-W/g'
> -Wlol
> $ echo -Wno-lol | sed 's/-Wno-/-W/g'
> -Wlol
Yep, but I wrote it like that to avoid spawning external
processes unless necessary. That adds up and slows configure down.
Thanks,
Pedro Alves
prev parent reply other threads:[~2015-12-16 23:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 22:58 Pedro Alves
2015-12-16 23:07 ` Simon Marchi
2015-12-16 23:13 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5671F01F.1070307@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox