From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95399 invoked by alias); 16 Dec 2015 23:13:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95386 invoked by uid 89); 16 Dec 2015 23:13:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 16 Dec 2015 23:13:38 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 281698CF73; Wed, 16 Dec 2015 23:13:37 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBGNDZWo002248; Wed, 16 Dec 2015 18:13:36 -0500 Message-ID: <5671F01F.1070307@redhat.com> Date: Wed, 16 Dec 2015 23:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix -Wno-unknown-warning support detection References: <1450306675-8885-1-git-send-email-palves@redhat.com> <5671EECA.4080206@ericsson.com> In-Reply-To: <5671EECA.4080206@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00314.txt.bz2 On 12/16/2015 11:07 PM, Simon Marchi wrote: > It looks good. I pushed it, thanks. Note that you could have done > > wtest=`echo $w | sed 's/-Wno-/-W/g'` > > unconditionally. If it doesn't match, it won't replace anything: > > $ echo -Wlol | sed 's/-Wno-/-W/g' > -Wlol > $ echo -Wno-lol | sed 's/-Wno-/-W/g' > -Wlol Yep, but I wrote it like that to avoid spawning external processes unless necessary. That adds up and slows configure down. Thanks, Pedro Alves