Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix regression revealed by corethreads.exp
Date: Thu, 10 Dec 2015 19:45:00 -0000	[thread overview]
Message-ID: <5669D64B.4020608@ericsson.com> (raw)
In-Reply-To: <5669D3BE.9050205@redhat.com>



On 12/10/2015 02:34 PM, Pedro Alves wrote:
> On 12/10/2015 07:14 PM, Antoine Tremblay wrote:
>> This patch fixes a regression introduced by:
>> https://sourceware.org/ml/gdb-patches/2015-12/msg00192.html
>>
>> We can't use thread_from_lwp with core files.  As mentioned in a comment,
>> td_ta_map_lwp2thr uses ps_get_thread_area, but we can't use that
>> currently on core targets, as it uses ptrace directly.
>>
>> Use directly record_thread instead.
>>
>> This fixes :
>> PASS -> FAIL: gdb.threads/corethreads.exp: thread0 found
>> PASS -> FAIL: gdb.threads/corethreads.exp: thread1 found
>>
>> gdb/ChangeLog:
>>
>> 	* linux-thread-db.c (find_new_threads_callback): Use record_thread.
>
> OK.
>

Pushed in.

Thanks,
Antoine


      reply	other threads:[~2015-12-10 19:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10 19:14 Antoine Tremblay
2015-12-10 19:34 ` Pedro Alves
2015-12-10 19:45   ` Antoine Tremblay [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5669D64B.4020608@ericsson.com \
    --to=antoine.tremblay@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox