From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6828 invoked by alias); 10 Dec 2015 19:45:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6802 invoked by uid 89); 10 Dec 2015 19:45:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 10 Dec 2015 19:45:18 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id D1.2D.32102.746D9665; Thu, 10 Dec 2015 20:45:11 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.95) with Microsoft SMTP Server id 14.3.248.2; Thu, 10 Dec 2015 14:45:15 -0500 Subject: Re: [PATCH] Fix regression revealed by corethreads.exp To: Pedro Alves , References: <1449774866-18369-1-git-send-email-antoine.tremblay@ericsson.com> <5669D3BE.9050205@redhat.com> From: Antoine Tremblay Message-ID: <5669D64B.4020608@ericsson.com> Date: Thu, 10 Dec 2015 19:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5669D3BE.9050205@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00213.txt.bz2 On 12/10/2015 02:34 PM, Pedro Alves wrote: > On 12/10/2015 07:14 PM, Antoine Tremblay wrote: >> This patch fixes a regression introduced by: >> https://sourceware.org/ml/gdb-patches/2015-12/msg00192.html >> >> We can't use thread_from_lwp with core files. As mentioned in a comment, >> td_ta_map_lwp2thr uses ps_get_thread_area, but we can't use that >> currently on core targets, as it uses ptrace directly. >> >> Use directly record_thread instead. >> >> This fixes : >> PASS -> FAIL: gdb.threads/corethreads.exp: thread0 found >> PASS -> FAIL: gdb.threads/corethreads.exp: thread1 found >> >> gdb/ChangeLog: >> >> * linux-thread-db.c (find_new_threads_callback): Use record_thread. > > OK. > Pushed in. Thanks, Antoine