Re: [PATCH v3 1/2] gdbserver: set ptrace flags after creating inferiors

[Pedro Alves <palves@redhat.com>]

Hi Josh,

Thanks for the update, and thanks for the new test.

On 12/04/2015 02:26 AM, Josh Stone wrote:

> 2015-12-03  Josh Stone  <jistone@redhat.com>
> 
> 	* gdb.base/catch-static-fork.exp: New.

Nit, to me, "catch-fork-static.exp" would be more natural.
As it reads as something about either "catch static" or
about a "static fork".

> +gdb_test "run" "Catchpoint \[0-9\]* \\(forked process \[0-9\]*\\),.*" \
> +    "run to fork"
> 

Please avoid hardcoding the "run" command:

gdb_run_cmd
gdb_test "" \
    "Catchpoint \[0-9\]* \\(forked process \[0-9\]*\\),.*" \
    "run to fork"

Even though "catch fork" currently doesn't work with plain
"target remote", which doesn't do "run", there are patches pending
to make it work.  With this change, this test should then work
with --target_board=native-gdbserver too.

OK with that change.

Thanks,
Pedro Alves