From: Josh Stone <jistone@redhat.com>
To: gdb-patches@sourceware.org
Cc: philippe.waroquiers@skynet.be, sergiodj@redhat.com,
palves@redhat.com, eliz@gnu.org, xdje42@gmail.com,
Josh Stone <jistone@redhat.com>
Subject: [PATCH v2 1/2] gdbserver: Set Linux ptrace options ASAP
Date: Thu, 26 Nov 2015 02:53:00 -0000 [thread overview]
Message-ID: <1448506425-24691-1-git-send-email-jistone@redhat.com> (raw)
In-Reply-To: <1446169946-28117-1-git-send-email-jistone@redhat.com>
The ptrace options should be set as soon as we know a thread is stopped,
so no events can be missed. There's an arch-setup early return that was
effectively delaying this update before, and I found for instance that
the first syscall event wouldn't be properly reported with TRACESYSGOOD.
It's now more similar to the way that gdb/linux-nat.c handles it.
gdb/gdbserver/ChangeLog:
2015-11-25 Josh Stone <jistone@redhat.com>
* linux-low.c (linux_low_filter_event): Set ptrace options as soon as
each thread is stopped, even before arch-specific setup.
---
gdb/gdbserver/linux-low.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
index e3a56a7c1690..9f577aefee1b 100644
--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -2249,6 +2249,16 @@ linux_low_filter_event (int lwpid, int wstat)
gdb_assert (WIFSTOPPED (wstat));
+ /* Set ptrace flags ASAP, so no events can be missed. */
+ if (WIFSTOPPED (wstat) && child->must_set_ptrace_flags)
+ {
+ struct process_info *proc = find_process_pid (pid_of (thread));
+ int options = linux_low_ptrace_options (proc->attached);
+
+ linux_enable_event_reporting (lwpid, options);
+ child->must_set_ptrace_flags = 0;
+ }
+
if (WIFSTOPPED (wstat))
{
struct process_info *proc;
@@ -2276,15 +2286,6 @@ linux_low_filter_event (int lwpid, int wstat)
}
}
- if (WIFSTOPPED (wstat) && child->must_set_ptrace_flags)
- {
- struct process_info *proc = find_process_pid (pid_of (thread));
- int options = linux_low_ptrace_options (proc->attached);
-
- linux_enable_event_reporting (lwpid, options);
- child->must_set_ptrace_flags = 0;
- }
-
/* Be careful to not overwrite stop_pc until
check_stopped_by_breakpoint is called. */
if (WIFSTOPPED (wstat) && WSTOPSIG (wstat) == SIGTRAP
--
2.5.0
next prev parent reply other threads:[~2015-11-26 2:53 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 11:02 [PATCH] Implement 'catch syscall' for gdbserver Josh Stone
2015-10-30 13:26 ` Eli Zaretskii
2015-11-01 22:15 ` Doug Evans
2015-11-02 18:24 ` Josh Stone
2015-11-21 10:29 ` Philippe Waroquiers
2015-11-23 4:20 ` Doug Evans
2015-11-23 4:20 ` Doug Evans
2015-11-25 2:37 ` Josh Stone
2015-11-26 2:53 ` Josh Stone [this message]
2015-11-26 2:54 ` [PATCH v2 2/2] " Josh Stone
2015-11-26 10:34 ` [PATCH v2 1/2] gdbserver: Set Linux ptrace options ASAP Pedro Alves
2015-11-30 18:50 ` Josh Stone
2015-12-01 20:17 ` Josh Stone
2015-12-02 14:01 ` Pedro Alves
2015-12-04 2:26 ` [PATCH v3 1/2] gdbserver: set ptrace flags after creating inferiors Josh Stone
2015-12-04 2:27 ` [PATCH v3 2/2] Implement 'catch syscall' for gdbserver Josh Stone
2015-12-04 8:45 ` Eli Zaretskii
2015-12-05 2:14 ` Josh Stone
2015-12-05 8:02 ` Eli Zaretskii
2015-12-07 16:50 ` Josh Stone
2015-12-07 17:15 ` Eli Zaretskii
2015-12-04 13:18 ` Pedro Alves
2015-12-05 2:16 ` Josh Stone
2015-12-08 13:31 ` Pedro Alves
2015-12-08 19:02 ` Josh Stone
2015-12-08 13:37 ` Pedro Alves
2015-12-11 21:19 ` Josh Stone
2015-12-16 15:42 ` Pedro Alves
2016-01-09 3:09 ` [PATCH v4] " Josh Stone
2016-01-09 7:37 ` Eli Zaretskii
2016-01-11 17:44 ` Philippe Waroquiers
2016-01-12 12:05 ` Pedro Alves
2016-01-12 19:10 ` Josh Stone
2016-01-12 19:22 ` Pedro Alves
2016-01-12 20:01 ` Josh Stone
2016-03-29 14:27 ` Yao Qi
2016-03-29 18:12 ` Josh Stone
2016-03-29 23:49 ` Josh Stone
2016-03-30 12:23 ` Yao Qi
2016-03-31 1:10 ` Josh Stone
2016-04-01 13:05 ` Yao Qi
2016-04-01 16:38 ` Josh Stone
2016-05-29 16:47 ` [doc] NEWS: QCatchSyscalls: simplify Jan Kratochvil
2016-05-29 17:29 ` Eli Zaretskii
2016-05-29 17:50 ` Jan Kratochvil
2016-05-29 18:19 ` Eli Zaretskii
2016-05-29 18:47 ` [commit] " Jan Kratochvil
2015-12-04 12:16 ` [PATCH v3 1/2] gdbserver: set ptrace flags after creating inferiors Pedro Alves
2015-12-05 2:14 ` Josh Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448506425-24691-1-git-send-email-jistone@redhat.com \
--to=jistone@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=philippe.waroquiers@skynet.be \
--cc=sergiodj@redhat.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox