Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Don Breazeal <donb@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix '-data-read-memory-bytes' typo/assertion
Date: Thu, 19 Nov 2015 23:06:00 -0000	[thread overview]
Message-ID: <564E5609.1010109@redhat.com> (raw)
In-Reply-To: <1447894382-1469-1-git-send-email-donb@codesourcery.com>

On 11/19/2015 12:53 AM, Don Breazeal wrote:

> gdb/
> 2015-11-18  Don Breazeal  <donb@codesourcery.com>
> 
> 	* gdb/target.c (read_memory_robust): Call
> 	read_whatever_is_readable with arguments in the correct order.
> 

Please drop the "gdb/" in the file name.

LGTM too.  Obvious even.  It'd be nice to have a testcase
for this though.  Seems like the simplest would be to just try
e.g., "-data-read-memory-bytes 8 1" and make sure that fails
with "Unable to read memory".  We'd just need to skip the
test if [is_address_zero_readable].

Thanks,
Pedro Alves


  parent reply	other threads:[~2015-11-19 23:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19  0:53 Don Breazeal
2015-11-19 13:27 ` Simon Marchi
2015-11-19 23:06 ` Pedro Alves [this message]
2015-11-20 18:02 ` [pushed][PATCH] " Don Breazeal
2016-02-03 12:37   ` Thomas Preud'homme
2016-02-04 18:23     ` Don Breazeal
2016-02-04 22:55       ` Don Breazeal
2016-02-04 23:02         ` Pedro Alves
2016-02-05  3:04           ` Thomas Preud'homme
2016-02-11 15:31             ` Don Breazeal
2016-02-15  4:58               ` Thomas Preud'homme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564E5609.1010109@redhat.com \
    --to=palves@redhat.com \
    --cc=donb@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox