From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55208 invoked by alias); 19 Nov 2015 23:06:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55089 invoked by uid 89); 19 Nov 2015 23:06:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 19 Nov 2015 23:06:52 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 9EA113B3C7; Thu, 19 Nov 2015 23:06:51 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAJN6oYe031812; Thu, 19 Nov 2015 18:06:50 -0500 Message-ID: <564E5609.1010109@redhat.com> Date: Thu, 19 Nov 2015 23:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Don Breazeal , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix '-data-read-memory-bytes' typo/assertion References: <1447894382-1469-1-git-send-email-donb@codesourcery.com> In-Reply-To: <1447894382-1469-1-git-send-email-donb@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00410.txt.bz2 On 11/19/2015 12:53 AM, Don Breazeal wrote: > gdb/ > 2015-11-18 Don Breazeal > > * gdb/target.c (read_memory_robust): Call > read_whatever_is_readable with arguments in the correct order. > Please drop the "gdb/" in the file name. LGTM too. Obvious even. It'd be nice to have a testcase for this though. Seems like the simplest would be to just try e.g., "-data-read-memory-bytes 8 1" and make sure that fails with "Unable to read memory". We'd just need to skip the test if [is_address_zero_readable]. Thanks, Pedro Alves