From: Khoo Yit Phang <khooyp@cs.umd.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Khoo Yit Phang <khooyp@cs.umd.edu>,
dje@google.com, brobecker@adacore.com, jan.kratochvil@redhat.com,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Also install data-directory into the build directory as computed by relocate_gdb_directory
Date: Sat, 06 Oct 2012 19:36:00 -0000 [thread overview]
Message-ID: <564A38E3-9230-4FEB-A53A-970BDA2C142B@cs.umd.edu> (raw)
In-Reply-To: <83a9vz769w.fsf@gnu.org>
Hi,
On Oct 6, 2012, at 3:24 PM, Eli Zaretskii wrote:
>> From: Khoo Yit Phang <khooyp@cs.umd.edu>
>> Date: Sat, 6 Oct 2012 15:02:00 -0400
>> Cc: Khoo Yit Phang <khooyp@cs.umd.edu>, Joel Brobecker <brobecker@adacore.com>, Jan Kratochvil <jan.kratochvil@redhat.com>, GDB Patches <gdb-patches@sourceware.org>
>>
>> I think the bigger issue is that $BUILDDIR/gdb/data-directory overrides the standard data-directory. If we detect run-from-builddir based on the presence of other files/directories, and some other application happens to use the same files/directories, then the user is basically stuck with either a non-working gdb (sans -data-directory) or having to uninstall that other application.
>
> I see no reason to assume that we will not be able to reliably detect
> a GDB build directory and to distinguish between that and other
> projects. Surely, we can find at least one or 2 files that only exist
> in GDB.
But we have to make assumptions about other applications that are not under our control, that they do not use the same files, which I think is an assumption that we should avoid if possible (who knows what's out there). Of course, we can greatly minimize the risk by checking for more files and/or the contents of files. But it is possible to avoid this assumption, e.g., the other two solutions in my previous email, hence my preferences.
Yit
October 6, 2012
next prev parent reply other threads:[~2012-10-06 19:36 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 20:33 [PATCH] Try to initialize data-directory by first searching for "data-directory" in the same directory as the gdb binary Khoo Yit Phang
2012-09-19 13:01 ` Jan Kratochvil
2012-09-19 19:53 ` [PATCH 1/2]: Refactor relocate_path to also check if the relocated file/directory exists Khoo Yit Phang
2012-09-21 18:27 ` Jan Kratochvil
2012-09-21 18:36 ` Eli Zaretskii
2012-09-21 18:46 ` Jan Kratochvil
2012-09-21 18:59 ` Eli Zaretskii
2012-09-21 19:09 ` Andreas Schwab
2012-09-22 16:07 ` Khoo Yit Phang
2012-09-25 6:59 ` Jan Kratochvil
2012-09-19 19:56 ` [PATCH 2/2] Try to initialize data-directory by first searching for "data-directory" in the same directory as the gdb binary Khoo Yit Phang
2012-09-21 18:31 ` Jan Kratochvil
2012-09-21 19:05 ` Khoo Yit Phang
2012-09-22 11:08 ` Jan Kratochvil
2012-09-22 15:50 ` Khoo Yit Phang
2012-09-24 7:30 ` Joel Brobecker
2012-09-24 13:14 ` Khoo Yit Phang
2012-09-24 14:24 ` Eli Zaretskii
2012-09-24 14:37 ` Khoo Yit Phang
2012-09-24 14:51 ` Eli Zaretskii
2012-09-24 15:00 ` Khoo Yit Phang
2012-09-24 15:27 ` Khoo Yit Phang
2012-09-24 15:49 ` Eli Zaretskii
2012-09-24 14:59 ` Joel Brobecker
2012-09-24 15:08 ` Khoo Yit Phang
2012-09-24 15:09 ` Eli Zaretskii
2012-09-24 15:12 ` Khoo Yit Phang
2012-09-24 15:27 ` Joel Brobecker
2012-09-24 16:10 ` Khoo Yit Phang
2012-09-24 16:45 ` Khoo Yit Phang
2012-09-24 17:04 ` Joel Brobecker
2012-09-24 19:19 ` [PATCH] Also install data-directory into the build directory as computed by relocate_gdb_directory Khoo Yit Phang
2012-09-27 9:17 ` Joel Brobecker
2012-09-27 14:57 ` Khoo Yit Phang
2012-10-03 21:31 ` Doug Evans
2012-10-04 0:09 ` Joel Brobecker
2012-10-04 0:50 ` Doug Evans
2012-10-04 1:34 ` Joel Brobecker
2012-10-04 3:41 ` Khoo Yit Phang
2012-10-04 13:39 ` Joel Brobecker
2012-10-04 14:26 ` Doug Evans
2012-10-04 14:25 ` Doug Evans
2012-10-04 14:51 ` Joel Brobecker
2012-10-04 15:07 ` Doug Evans
2012-10-04 15:28 ` Joel Brobecker
2012-10-06 19:02 ` Khoo Yit Phang
2012-10-06 19:25 ` Eli Zaretskii
2012-10-06 19:36 ` Khoo Yit Phang [this message]
2012-10-06 20:07 ` Eli Zaretskii
2012-10-06 20:12 ` Khoo Yit Phang
2012-10-06 20:29 ` Eli Zaretskii
2012-10-06 20:32 ` Khoo Yit Phang
2012-10-06 21:00 ` Eli Zaretskii
2012-10-08 16:33 ` Doug Evans
2012-10-08 20:13 ` Khoo Yit Phang
2012-10-08 20:24 ` Doug Evans
2012-10-09 5:48 ` Joel Brobecker
2012-10-09 16:49 ` Eli Zaretskii
2012-10-04 3:43 ` Eli Zaretskii
2012-10-04 13:49 ` Joel Brobecker
2012-10-04 14:48 ` Doug Evans
2012-10-04 15:23 ` Doug Evans
2012-10-04 17:07 ` Eli Zaretskii
2012-09-24 18:12 ` [PATCH 2/2] Try to initialize data-directory by first searching for "data-directory" in the same directory as the gdb binary Eli Zaretskii
2012-09-24 20:49 ` Joel Brobecker
2012-09-24 21:08 ` Eli Zaretskii
2012-09-24 21:37 ` Joel Brobecker
2012-09-25 6:29 ` Eli Zaretskii
2012-09-25 6:35 ` Joel Brobecker
2012-09-25 6:50 ` Eli Zaretskii
2012-09-25 7:02 ` Joel Brobecker
2012-09-24 18:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564A38E3-9230-4FEB-A53A-970BDA2C142B@cs.umd.edu \
--to=khooyp@cs.umd.edu \
--cc=brobecker@adacore.com \
--cc=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox