Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: Khoo Yit Phang <khooyp@cs.umd.edu>,
	Jan Kratochvil <jan.kratochvil@redhat.com>,
	GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Also install data-directory into the build directory as computed by relocate_gdb_directory
Date: Thu, 04 Oct 2012 01:34:00 -0000	[thread overview]
Message-ID: <20121004013358.GJ3028@adacore.com> (raw)
In-Reply-To: <CADPb22TcGqvuxKo5_t8zuwNiJyUL4Yp38zA0OXcX_Dbv9bmyNQ@mail.gmail.com>

> I think(!) this "can't happen" (if I understand the patch correctly),
> the installed directory will always be a subdir of $(top_builddir)/..
> It may be a useless subdirectory of $(top_builddir)/.., but at least
> it's in the build tree. :-)
> [Again, assuming I understand the patch correctly.]

You might be right - I might have missed that. But the patch cannot
be applied as is, as it relies on a GNU Make feature. So we were
going to adapt it to use sed instead.

> >   2. Accept the new situation, and configure with a --prefix somewhere
> >      in the build directory. I can do an install the first time, and
> >      then as needed based on what changes have been made since the
> >      last install...
> 
> Not sure I understand, but for reference sake,
> Our builds always do a "make install" into a staging area, though we
> configure --prefix=/usr.

I finally figured out what DESTDIR is for. Almost like a chroot
kind of thing. Neat!

What I was saying is a little TMI for what we were discussing. It
was just an example of what I do to get something installed somewhere.
I could do it your way, but it's easier with a configure-time option...

> > It's a pain in the neck, but I think I have slowly been coming to
> > the conclusion that it is probably best for me, and the others who
> > were relying on this undocumented feature, to learn to live with
> > the new requirement. At least we tried...
> 
> I'd be ok with a short option that said "I'm running from the build
> directory, deal with it." :-)
> E..g,
> bash$ ./gdb -b
> [alas -b is taken, but I hope you get the idea]

I don't think that it'll be necessary. Practically speaking, it's
easier to just do that one install, and keep it until some change
makes it need an update.

> Another wild idea is to rename the gdb in the build directory as xgdb
> (akin to xgcc).  One could key off that to know gdb is being run from
> the build directory.

I think that this is opening the door for allowing GDB to execute
code without the user being aware of it. I'd rather avoid that.

> btw, Is there a use-case of yours that I'm missing?

I do not think so. It's mostly a case where I build and then test
right away using the binary in the build directory. I've been doing
that for the past 12 years, and I find it saves time, albeit only
a little. I was exploring the idea of trying to preserve this
behavior. But I think the cost might be exceeding the benefits.

Thanks for looking into this with us, though. This is not to say
that the discussion is over; just that, so far, the options suggested
don't really help enough to be worth implementing (IMO).

-- 
Joel


  reply	other threads:[~2012-10-04  1:34 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18 20:33 [PATCH] Try to initialize data-directory by first searching for "data-directory" in the same directory as the gdb binary Khoo Yit Phang
2012-09-19 13:01 ` Jan Kratochvil
2012-09-19 19:53   ` [PATCH 1/2]: Refactor relocate_path to also check if the relocated file/directory exists Khoo Yit Phang
2012-09-21 18:27     ` Jan Kratochvil
2012-09-21 18:36       ` Eli Zaretskii
2012-09-21 18:46         ` Jan Kratochvil
2012-09-21 18:59           ` Eli Zaretskii
2012-09-21 19:09           ` Andreas Schwab
2012-09-22 16:07             ` Khoo Yit Phang
2012-09-25  6:59               ` Jan Kratochvil
2012-09-19 19:56   ` [PATCH 2/2] Try to initialize data-directory by first searching for "data-directory" in the same directory as the gdb binary Khoo Yit Phang
2012-09-21 18:31     ` Jan Kratochvil
2012-09-21 19:05       ` Khoo Yit Phang
2012-09-22 11:08         ` Jan Kratochvil
2012-09-22 15:50           ` Khoo Yit Phang
2012-09-24  7:30             ` Joel Brobecker
2012-09-24 13:14               ` Khoo Yit Phang
2012-09-24 14:24                 ` Eli Zaretskii
2012-09-24 14:37                   ` Khoo Yit Phang
2012-09-24 14:51                     ` Eli Zaretskii
2012-09-24 15:00                       ` Khoo Yit Phang
2012-09-24 15:27                         ` Khoo Yit Phang
2012-09-24 15:49                           ` Eli Zaretskii
2012-09-24 14:59                 ` Joel Brobecker
2012-09-24 15:08                   ` Khoo Yit Phang
2012-09-24 15:09                   ` Eli Zaretskii
2012-09-24 15:12                   ` Khoo Yit Phang
2012-09-24 15:27                     ` Joel Brobecker
2012-09-24 16:10                       ` Khoo Yit Phang
2012-09-24 16:45                         ` Khoo Yit Phang
2012-09-24 17:04                           ` Joel Brobecker
2012-09-24 19:19                             ` [PATCH] Also install data-directory into the build directory as computed by relocate_gdb_directory Khoo Yit Phang
2012-09-27  9:17                               ` Joel Brobecker
2012-09-27 14:57                                 ` Khoo Yit Phang
2012-10-03 21:31                                 ` Doug Evans
2012-10-04  0:09                                   ` Joel Brobecker
2012-10-04  0:50                                     ` Doug Evans
2012-10-04  1:34                                       ` Joel Brobecker [this message]
2012-10-04  3:41                                         ` Khoo Yit Phang
2012-10-04 13:39                                           ` Joel Brobecker
2012-10-04 14:26                                           ` Doug Evans
2012-10-04 14:25                                         ` Doug Evans
2012-10-04 14:51                                           ` Joel Brobecker
2012-10-04 15:07                                             ` Doug Evans
2012-10-04 15:28                                               ` Joel Brobecker
2012-10-06 19:02                                               ` Khoo Yit Phang
2012-10-06 19:25                                                 ` Eli Zaretskii
2012-10-06 19:36                                                   ` Khoo Yit Phang
2012-10-06 20:07                                                     ` Eli Zaretskii
2012-10-06 20:12                                                       ` Khoo Yit Phang
2012-10-06 20:29                                                         ` Eli Zaretskii
2012-10-06 20:32                                                           ` Khoo Yit Phang
2012-10-06 21:00                                                             ` Eli Zaretskii
2012-10-08 16:33                                                 ` Doug Evans
2012-10-08 20:13                                                   ` Khoo Yit Phang
2012-10-08 20:24                                                     ` Doug Evans
2012-10-09  5:48                                                   ` Joel Brobecker
2012-10-09 16:49                                                     ` Eli Zaretskii
2012-10-04  3:43                                     ` Eli Zaretskii
2012-10-04 13:49                                       ` Joel Brobecker
2012-10-04 14:48                                         ` Doug Evans
2012-10-04 15:23                                           ` Doug Evans
2012-10-04 17:07                                         ` Eli Zaretskii
2012-09-24 18:12                           ` [PATCH 2/2] Try to initialize data-directory by first searching for "data-directory" in the same directory as the gdb binary Eli Zaretskii
2012-09-24 20:49                             ` Joel Brobecker
2012-09-24 21:08                               ` Eli Zaretskii
2012-09-24 21:37                                 ` Joel Brobecker
2012-09-25  6:29                                   ` Eli Zaretskii
2012-09-25  6:35                                     ` Joel Brobecker
2012-09-25  6:50                                       ` Eli Zaretskii
2012-09-25  7:02                                         ` Joel Brobecker
2012-09-24 18:11                         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121004013358.GJ3028@adacore.com \
    --to=brobecker@adacore.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=khooyp@cs.umd.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox